Git development
 help / color / mirror / Atom feed
From: Olof Fairbrook <olof.fairbrook@gmail.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bundle: do not free uninitialized memory on bad arguments
Date: Mon, 19 Oct 2026 12:35:14 +0200 (CEST)	[thread overview]
Message-ID: <947bafea-8f2b-9865-0dcf-c5de1c7853f9@gmail.com> (raw)
In-Reply-To: <CAHwyqnWxr3ZhPpM0WPCnJh-SHdGDZNE0ZJwA1jHhd+6-f0aEcw@mail.gmail.com>



On Mon, 19 Oct 2026, Harald Nordgren wrote:

>> -       struct rev_info revs, revs_copy;
>> +       struct rev_info revs, revs_copy = { 0 };
>
> I'm not familiar with this code, but the fix seems simple enough and
> has a test. Looks good.
>
>
> Harald
>

Thanks for the review!
Olof

  reply	other threads:[~2026-10-19 10:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 14:21 [PATCH] bundle: do not free uninitialized memory on bad arguments Olof Fairbrook
2026-10-19  6:51 ` Patrick Steinhardt
2026-10-19 10:25   ` Olof Fairbrook
2026-10-19  9:40 ` Harald Nordgren
2026-10-19 10:35   ` Olof Fairbrook [this message]
2026-10-19 16:07 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=947bafea-8f2b-9865-0dcf-c5de1c7853f9@gmail.com \
    --to=olof.fairbrook@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox