From: Olof Fairbrook <olof.fairbrook@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Olof Fairbrook <olof.fairbrook@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] bundle: do not free uninitialized memory on bad arguments
Date: Mon, 19 Oct 2026 12:25:12 +0200 (CEST) [thread overview]
Message-ID: <c9d2099e-4eab-6be2-10a3-c30f33c88b8b@gmail.com> (raw)
In-Reply-To: <atW95CyeiQCGtIMX@pks.im>
On Mon, 19 Oct 2026, Patrick Steinhardt wrote:
>> in object_array_clear() and in free(); whether the command crashes
>> depends on what happens to be on the stack.
>
> Nit: that last sentence is a bit on the verbose side, as it doesn't
> really give any more useful information. I'd just drop it.
Yes, agreed. Just me over explaining. Will keep that in mind for future
messages on the list.
>> test_commit -C foo x &&
>
> I think overall this looks good enough already, and the nits I have
> raised do not really need to be addressed.
>
> Thanks!
>
> Patrick
>
Thank you!
Olof
next prev parent reply other threads:[~2026-10-19 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 14:21 [PATCH] bundle: do not free uninitialized memory on bad arguments Olof Fairbrook
2026-10-19 6:51 ` Patrick Steinhardt
2026-10-19 10:25 ` Olof Fairbrook [this message]
2026-10-19 9:40 ` Harald Nordgren
2026-10-19 10:35 ` Olof Fairbrook
2026-10-19 16:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d2099e-4eab-6be2-10a3-c30f33c88b8b@gmail.com \
--to=olof.fairbrook@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox