From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>, git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH v2 01/20] t9300: move 'fastimport.unpackLimit' to the required test
Date: Thu, 19 Nov 2026 15:36:16 +0530 [thread overview]
Message-ID: <953176e8-e475-4a99-b2d3-725fd346c19e@gmail.com> (raw)
In-Reply-To: <20261112-kn-fast-import-tests-1-v2-1-b8c3a0ab27e8@gmail.com>
On 11/12/26 23:04, Karthik Nayak wrote:
> The 'empty stream succeeds' test sets 'fastimport.unpackLimit' to '0',
> so that the following imports write packs for the 'verify pack' tests
> to check. The test itself doesn't need it. A following commit makes it
> run in its own repository, where the setting would no longer reach the
> tests after it.
>
> Move the configuration to 'A: create pack from stdin', the first test
> which needs it. The configuration must persist for the 'verify pack'
> tests of the following series, so set it with 'git config' and not with
> 'test_config'.
>
This makes me wonder if there is another patch later in this series to
turn the 'git config fastimport.unpackLimit' into one that uses
test_config instead to make the tests more self contained. Or may be it
is planned in the follow-up the cover letter mentions.
I'll see about it. In any case, I think it may be worth a noting in the
commit message your thoughts about a change that turns the 'git config'
into a test_config one.
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> t/t9300-fast-import.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
> index 15f511fb6b..4cffe43a71 100755
> --- a/t/t9300-fast-import.sh
> +++ b/t/t9300-fast-import.sh
> @@ -38,7 +38,6 @@ echo "$@"'
> ###
>
> test_expect_success 'empty stream succeeds' '
> - git config fastimport.unpackLimit 0 &&
> git fast-import </dev/null
> '
>
> @@ -47,6 +46,7 @@ test_expect_success 'truncated stream complains' '
> '
>
> test_expect_success 'A: create pack from stdin' '
> + git config fastimport.unpackLimit 0 &&
> test_tick &&
> cat >input <<-INPUT_END &&
> blob
>
Change itself looks good to me.
--
Sivaraam
next prev parent reply other threads:[~2026-11-19 10:06 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:49 [PATCH 00/20] t9300: group and move tests to other files Karthik Nayak
2026-11-10 11:49 ` [PATCH 01/20] t9300: move 'fastimport.unpackLimit' to the required test Karthik Nayak
2026-11-10 11:49 ` [PATCH 02/20] t9300: make the series B tests self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 03/20] t9300: make the series T " Karthik Nayak
2026-11-10 11:49 ` [PATCH 04/20] t9300: make the series S " Karthik Nayak
2026-11-10 11:49 ` [PATCH 05/20] t9300: make the series V " Karthik Nayak
2026-11-10 11:49 ` [PATCH 06/20] t9300: make the series Q " Karthik Nayak
2026-11-10 11:49 ` [PATCH 07/20] t9300: make the series P " Karthik Nayak
2026-11-10 11:49 ` [PATCH 08/20] t9300: make the series O " Karthik Nayak
2026-11-10 11:49 ` [PATCH 09/20] t9300: make the big blob " Karthik Nayak
2026-11-10 11:49 ` [PATCH 10/20] t9300: make the ref update " Karthik Nayak
2026-11-10 11:49 ` [PATCH 11/20] t9300: make the date format " Karthik Nayak
2026-11-10 11:49 ` [PATCH 12/20] t9300: make the pack edges test self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 13/20] t9300: make the marks tests self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 14/20] t9300: make the series Y " Karthik Nayak
2026-11-10 11:50 ` [PATCH 15/20] t9300: make the cat-blob " Karthik Nayak
2026-11-10 11:50 ` [PATCH 16/20] t9300: make the feature and option " Karthik Nayak
2026-11-10 11:50 ` [PATCH 17/20] t9300: make the stream " Karthik Nayak
2026-11-10 11:50 ` [PATCH 18/20] t9300: make the get-mark and encoding " Karthik Nayak
2026-11-10 11:50 ` [PATCH 19/20] t9300: move self-contained tests into dedicated files Karthik Nayak
2026-11-10 11:50 ` [PATCH 20/20] t93xx: drop the series letter from the moved test names Karthik Nayak
2026-11-10 16:45 ` [PATCH 00/20] t9300: group and move tests to other files Junio C Hamano
2026-11-10 20:06 ` Junio C Hamano
2026-11-11 11:22 ` Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 01/20] t9300: move 'fastimport.unpackLimit' to the required test Karthik Nayak
2026-11-19 10:06 ` Kaartic Sivaraam [this message]
2026-11-12 17:34 ` [PATCH v2 02/20] t9300: make the series B tests self-contained Karthik Nayak
2026-11-19 12:22 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 03/20] t9300: make the series T " Karthik Nayak
2026-11-19 12:45 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 04/20] t9300: make the series S " Karthik Nayak
2026-11-19 18:27 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 05/20] t9300: make the series V " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 06/20] t9300: make the series Q " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 07/20] t9300: make the series P " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 08/20] t9300: make the series O " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 09/20] t9300: make the big blob " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 10/20] t9300: make the ref update " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 11/20] t9300: make the date format " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 12/20] t9300: make the pack edges test self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 13/20] t9300: make the marks tests self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 14/20] t9300: make the series Y " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 15/20] t9300: make the cat-blob " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 16/20] t9300: make the feature and option " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 17/20] t9300: make the stream " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 18/20] t9300: make the get-mark and encoding " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 19/20] t9300: move self-contained tests into dedicated files Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 20/20] t93xx: drop the series letter from the moved test names Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953176e8-e475-4a99-b2d3-725fd346c19e@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).