From: Phillip Wood <phillip.wood123@gmail.com>
To: Harald Nordgren <haraldnordgren@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] rebase: mention --abort alongside --continue
Date: Sat, 18 Jul 2026 10:25:56 +0100 [thread overview]
Message-ID: <9a0b542c-8984-4d73-8e24-00adf6dcd427@gmail.com> (raw)
In-Reply-To: <CAHwyqnVwDsdvvg6a2BtAYw+hYRdgKvRXwHE+uzAZjherfu5B=Q@mail.gmail.com>
On 18/07/2026 09:05, Harald Nordgren wrote:
>> I wonder if the workflow that benefits from this "if exec fails,
>> give up and forget the whole thing" behavior is actually quite
>> different from what we consider the "normal" use of the command?
>> Perhaps the user is not interested in "rebasing" the history at
>> all, but is instead running a check on each and every commit.
>> That is, a more expensive version of:
>>
>> for commit in $(git rev-list bottom..top)
>> do
>> git reset --hard "$commit" &&
>> do the exec command || break
>> done
>>
>> that just happens to be shorter to type?
>> Sure, that's exactly right.
I think I must be missing something; I had assumed that someone running
a check on each commit wanted to ensure it passed, and, if not, they
would want to fix the problem that caused the check to fail. In that
case I would expect that they would want to amend the failing commit,
rather than abort the rebase. What's the scenario where one wants to
check a bunch of commits but not fix the ones that fail?
Thanks
Phillip
next prev parent reply other threads:[~2026-07-18 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 19:19 [PATCH] rebase: mention --abort alongside --continue Harald Nordgren via GitGitGadget
2026-06-16 8:36 ` Phillip Wood
2026-06-16 17:33 ` Junio C Hamano
2026-06-17 8:56 ` Harald Nordgren
2026-06-17 9:52 ` Phillip Wood
2026-06-17 12:19 ` Junio C Hamano
2026-06-18 18:49 ` Harald Nordgren
2026-06-19 1:36 ` Junio C Hamano
2026-07-16 6:02 ` Harald Nordgren
2026-07-16 9:37 ` Phillip Wood
2026-07-16 17:24 ` Junio C Hamano
2026-07-18 8:05 ` Harald Nordgren
2026-07-18 9:25 ` Phillip Wood [this message]
2026-07-20 2:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a0b542c-8984-4d73-8e24-00adf6dcd427@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox