From: Sean <seanlkml@sympatico.ca>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow pickaxe to be used via git log.
Date: Thu, 18 May 2006 22:56:12 -0400 [thread overview]
Message-ID: <BAYC1-PASMTP07581788E7BAAC19B2A159AEA70@CEZ.ICE> (raw)
Message-ID: <20060518225612.16c6441f.seanlkml@sympatico.ca> (raw)
In-Reply-To: <7v4pzmn32g.fsf@assigned-by-dhcp.cox.net>
On Thu, 18 May 2006 19:47:19 -0700
Junio C Hamano <junkio@cox.net> wrote:
> If that (specifically, "when passed to git log") is what you
> want, do all of that in "git log" please. I haven't checked,
> but I suspect your changes would break git-rev-list and makes it
> disobey the options the user gives it.
>
Well, it's more general than just git log, but that's primarily where one
would see it. Essentially the patch is saying that specifying both a
"revs->diffopt.pickaxe" string and "revs->always_show_header" is illegal
and proceeds to use pickaxe instead of the other.
Is there any place that depends on the ability to specify both a pickaxe
string _and_ always_show_header? If not, it's hard to see how this patch
could break anything.
Sean
next prev parent reply other threads:[~2006-05-19 3:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060518213124.6e731eef.seanlkml@sympatico.ca>
2006-05-19 1:31 ` [PATCH] Allow pickaxe to be used via git log Sean
2006-05-19 2:47 ` Junio C Hamano
[not found] ` <20060518225612.16c6441f.seanlkml@sympatico.ca>
2006-05-19 2:56 ` Sean [this message]
2006-05-19 3:05 ` Junio C Hamano
[not found] ` <20060518233803.7e4ca954.seanlkml@sympatico.ca>
2006-05-19 3:38 ` Sean
2006-05-19 3:39 ` Junio C Hamano
[not found] ` <20060519001920.42990900.seanlkml@sympatico.ca>
2006-05-19 4:19 ` [PATCH] Allow pickaxe and diff-filter options to be used by " Sean
2006-05-19 5:41 ` Junio C Hamano
[not found] ` <20060519014938.272dd7a1.seanlkml@sympatico.ca>
2006-05-19 5:49 ` Sean
2006-05-19 6:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAYC1-PASMTP07581788E7BAAC19B2A159AEA70@CEZ.ICE \
--to=seanlkml@sympatico.ca \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox