Git development
 help / color / mirror / Atom feed
* [PATCH v2] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh
@ 2026-08-31 18:45 Hardik Kumar
  2026-08-31 19:01 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Hardik Kumar @ 2026-08-31 18:45 UTC (permalink / raw)
  To: git; +Cc: Hardik Kumar

The patch fixes two typos in two places.
versoncmp.c:            "fractionnal" -> "fractional"
t/t0022-crlf-rename.sh: "similiarity" -> "similarity"

No functional changes, only update a comment and a test_description.

Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
---
Changes in v2:
- refactor commit message
- Link to v1: https://lore.kernel.org/r/20260828-typo-fix-v1-1-24e80a87ed53@gmail.com
---
 t/t0022-crlf-rename.sh | 2 +-
 versioncmp.c           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
index 9bd863a970..328c6e5903 100755
--- a/t/t0022-crlf-rename.sh
+++ b/t/t0022-crlf-rename.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-test_description='ignore CR in CRLF sequence while computing similiarity'
+test_description='ignore CR in CRLF sequence while computing similarity'
 
 . ./test-lib.sh
 
diff --git a/versioncmp.c b/versioncmp.c
index 3a81b17bc1..f1e451755a 100644
--- a/versioncmp.c
+++ b/versioncmp.c
@@ -15,7 +15,7 @@
 
 /*
  * states: S_N: normal, S_I: comparing integral part, S_F: comparing
- * fractionnal parts, S_Z: idem but with leading Zeroes only
+ * fractional parts, S_Z: idem but with leading Zeroes only
  */
 #define  S_N    0x0
 #define  S_I    0x3

---
base-commit: f78ce2f7b6df702f93d40b85d6bda92a3f65da79
change-id: 20260828-typo-fix-721b77177721


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh
  2026-08-31 18:45 [PATCH v2] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Hardik Kumar
@ 2026-08-31 19:01 ` Junio C Hamano
  2026-08-31 19:29   ` Hardik Kumar
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2026-08-31 19:01 UTC (permalink / raw)
  To: Hardik Kumar; +Cc: git

Hardik Kumar <hardikxk@gmail.com> writes:

> The patch fixes two typos in two places.
> versoncmp.c:            "fractionnal" -> "fractional"

Verson???

> t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
>
> No functional changes, only update a comment and a test_description.
>
> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
> ---
> Changes in v2:
> - refactor commit message
> - Link to v1: https://lore.kernel.org/r/20260828-typo-fix-v1-1-24e80a87ed53@gmail.com
> ---
>  t/t0022-crlf-rename.sh | 2 +-
>  versioncmp.c           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
> index 9bd863a970..328c6e5903 100755
> --- a/t/t0022-crlf-rename.sh
> +++ b/t/t0022-crlf-rename.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -test_description='ignore CR in CRLF sequence while computing similiarity'
> +test_description='ignore CR in CRLF sequence while computing similarity'
>  
>  . ./test-lib.sh
>  
> diff --git a/versioncmp.c b/versioncmp.c
> index 3a81b17bc1..f1e451755a 100644
> --- a/versioncmp.c
> +++ b/versioncmp.c
> @@ -15,7 +15,7 @@
>  
>  /*
>   * states: S_N: normal, S_I: comparing integral part, S_F: comparing
> - * fractionnal parts, S_Z: idem but with leading Zeroes only
> + * fractional parts, S_Z: idem but with leading Zeroes only
>   */
>  #define  S_N    0x0
>  #define  S_I    0x3
>
> ---
> base-commit: f78ce2f7b6df702f93d40b85d6bda92a3f65da79
> change-id: 20260828-typo-fix-721b77177721

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh
  2026-08-31 19:01 ` Junio C Hamano
@ 2026-08-31 19:29   ` Hardik Kumar
  0 siblings, 0 replies; 3+ messages in thread
From: Hardik Kumar @ 2026-08-31 19:29 UTC (permalink / raw)
  To: Junio C Hamano, Hardik Kumar; +Cc: git

On Tue Sep 1, 2026 at 12:31 AM IST, Junio C Hamano wrote:
> Hardik Kumar <hardikxk@gmail.com> writes:
>
>> The patch fixes two typos in two places.
>> versoncmp.c:            "fractionnal" -> "fractional"
>
> Verson???

Thats ironic. Fixed in follow up.

Thanks.

Hardik

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-31 19:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 18:45 [PATCH v2] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Hardik Kumar
2026-08-31 19:01 ` Junio C Hamano
2026-08-31 19:29   ` Hardik Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox