From: "Farid Zakaria" <farid.m.zakaria@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Farid Zakaria" <farid.m.zakaria@gmail.com>
Cc: <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
"Patrick Steinhardt" <ps@pks.im>,
"M Hickford" <mirth.hickford@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Jeff Hostetler" <jeffhostetler@github.com>
Subject: Re: [PATCH v2 0/3] credential-cache: fix two races when daemons start at once
Date: Sat, 07 Nov 2026 20:27:43 -0800 [thread overview]
Message-ID: <DMPJNBIHZB35.1EJF34BS6RR9@gmail.com> (raw)
In-Reply-To: <xmqq33tc84rk.fsf@gitster.g>
On Sat Nov 7, 2026 at 5:56 PM PST, Junio C Hamano wrote:
> "Farid Zakaria" <farid.m.zakaria@gmail.com> writes:
>
>> It was not clear to me as someone unfamiliar with the codebase
>> whether the complexity of handling it was worth it. It seemed like
>> it could only occur during upgrades (old git version). My comment
>> was meant to say: I did not address it but I can if we think it's
>> necessary.
>
> I am not sure if I follow your "upgrades (old git version)"
> reference. Doesn't a reasonably serious installation of any
> software have a babysitter process to notice a dead daemon to
> automatically respawn to keep the service running?
>
> If you are unfamiliar with the codebase, how would you know which of
> the careful arrangements the existing code makes can be ignored? If
> it is not important, what would the reason be for reviewers to spend
> time and effort to write a message to point it out for you?
I'm not sure how you want me to respond here;
I made an attempt at a fix for an issue I came across
within the context I felt comfortable to contribute.
I tried to capture that within my cover letter.
prev parent reply other threads:[~2026-11-08 4:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 23:29 [PATCH 0/2] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-01 23:29 ` [PATCH 1/2] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:25 ` Farid Zakaria
2026-11-04 2:58 ` Jeff King
2026-11-01 23:29 ` [PATCH 2/2] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:28 ` Farid Zakaria
2026-11-03 17:24 ` Junio C Hamano
2026-11-04 3:07 ` Jeff King
2026-11-04 19:53 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 1/3] credential-cache--daemon: do not apply core.sharedRepository Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 2/3] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 3/3] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-05 7:39 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Junio C Hamano
2026-11-06 18:45 ` Farid Zakaria
2026-11-08 1:56 ` Junio C Hamano
2026-11-08 4:27 ` Farid Zakaria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMPJNBIHZB35.1EJF34BS6RR9@gmail.com \
--to=farid.m.zakaria@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhostetler@github.com \
--cc=mirth.hickford@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox