From: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: <git@vger.kernel.org>, <jltobler@gmail.com>, <ps@pks.im>
Subject: Re: [PATCH v7 1/1] repo: add filtering options to "repo structure"
Date: Wed, 18 Nov 2026 14:30:16 -0500 [thread overview]
Message-ID: <DMYL3TCBEMAJ.2MW8J9PLG9ZD@fastmail.com> (raw)
In-Reply-To: <xmqq33u5c6z6.fsf@gitster.g>
On Fri Oct 16, 2026 at 11:59 PM EDT, Junio C Hamano wrote:
> "Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
>
>> t/t1901-repo-structure.sh | 197 ++++++++++++++++++++++++++++++++++++
>
> This test is broken with SHA-256 and in Git 3.0.
>
>> +test_expect_success 'filter by object type' '
>
> This hardcodes many 40 hexdigits constants, like ...
>
>> + test_when_finished "rm -rf repo" &&
>> + git init repo &&
>> + (
>> ...
>> + objects.blobs.max_size=13
>> + objects.blobs.max_size_oid=97d808e45116bf02103490294d3d46dad7a2ac62
>
> ... this one, which is very specific to SHA-1. Existing tests in
> this file (like the one immediately after this one) protects such a
> test with SHA1 prerequisite to avoid breaking in SHA-256
> environment, which is far from ideal but better than leaving it
> broken. In the longer term, we should strive to get rid of use of
> SHA1 prerequisites, as SHA-256 will be becoming the default in not
> so distant future versions of Git.
>
>> test_expect_success SHA1 'lines and nul format' '
>> test_when_finished "rm -rf repo" &&
>> git init repo &&
>
> If you choose to fix them, see recent effort by others for
> inspiration to make sure you can share and reuse most of this test
> between two supported hash functions, e.g. the discussion that lead
> to
>
> https://lore.kernel.org/git/pull.2252.v4.git.1792012956734.gitgitgadget@gmail.com/
>
> but you may choose to punt and just put your broken test under SHA1
> prerequisite to sweep the breakage under the rug just like other
> existing tests in this file.
Sorry for the delay in responding to this; I missed this message.
I think that the best approach for now is to put this under SHA1,
then I'll take on updating all of the tests in this file to get rid
ofthe SHA1 prerequisite.
-Mark
--
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com
next prev parent reply other threads:[~2026-11-18 19:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 16:45 [PATCH 0/1] repo: add filtering options to "repo structure" Mark C. Chu-Carroll
2026-09-24 16:45 ` [PATCH 1/1] " Mark C. Chu-Carroll
2026-09-30 16:28 ` Patrick Steinhardt
2026-10-05 18:52 ` Mark C. Chu-Carroll
2026-10-05 17:40 ` [PATCH v2 0/1] " Mark C. Chu-Carroll
2026-10-05 17:40 ` [PATCH v2 1/1] " Mark C. Chu-Carroll
2026-10-06 5:51 ` Patrick Steinhardt
2026-10-08 15:46 ` Kaartic Sivaraam
2026-10-09 15:49 ` Mark C. Chu-Carroll
2026-10-09 18:09 ` [PATCH v3 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-09 18:09 ` [PATCH v3 1/1] repo: add " Mark C. Chu-Carroll
2026-10-09 21:24 ` Junio C Hamano
2026-10-10 14:31 ` Mark C. Chu-Carroll
2026-10-10 15:05 ` [PATCH v4 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-10 15:05 ` [PATCH v4 1/1] repo: add " Mark C. Chu-Carroll
2026-10-13 11:50 ` Patrick Steinhardt
2026-10-13 13:56 ` Mark C. Chu-Carroll
2026-10-13 14:05 ` Patrick Steinhardt
2026-10-13 17:28 ` [PATCH v5 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-13 17:28 ` [PATCH v5 1/1] repo: add " Mark C. Chu-Carroll
2026-10-14 12:15 ` Patrick Steinhardt
2026-10-15 14:44 ` Mark C. Chu-Carroll
2026-10-15 15:52 ` Patrick Steinhardt
2026-10-15 14:46 ` [PATCH v6 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-15 14:46 ` [PATCH v6 1/1] repo: add " Mark C. Chu-Carroll
2026-10-15 15:12 ` Kristoffer Haugsbakk
2026-10-15 16:58 ` Mark C. Chu-Carroll
2026-10-15 17:03 ` [PATCH v7 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-15 17:03 ` [PATCH v7 1/1] repo: add " Mark C. Chu-Carroll
2026-10-17 3:59 ` Junio C Hamano
2026-11-18 19:30 ` Mark C. Chu-Carroll [this message]
2026-10-15 17:05 ` [PATCH v7 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-15 17:05 ` [PATCH v7 1/1] repo: add " Mark C. Chu-Carroll
2026-10-16 5:31 ` [PATCH v7 0/1] repo: add revision " Patrick Steinhardt
2026-10-16 13:31 ` Mark C. Chu-Carroll
2026-10-16 13:31 ` [PATCH v7 1/1] repo: add " Mark C. Chu-Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMYL3TCBEMAJ.2MW8J9PLG9ZD@fastmail.com \
--to=markchucarroll@fastmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox