From: Linus Torvalds <torvalds@osdl.org>
To: Sven Verdoolaege <skimo@liacs.nl>
Cc: git@vger.kernel.org
Subject: Re: rev-parse, unknown arguments and extended sha1's
Date: Fri, 24 Jun 2005 09:09:23 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0506240904240.11175@ppc970.osdl.org> (raw)
In-Reply-To: <20050624122436.GA15182@pc117b.liacs.nl>
On Fri, 24 Jun 2005, Sven Verdoolaege wrote:
>
> Is git-rev-parse supposed to echo arguments it doesn't understand ?
> It currently does, but git-checkout-script seems to think it doesn't:
>
> rev=$(git-rev-parse "$arg")
> if [ -z "$rev" ]; then
> echo "unknown flag $arg"
> exit 1
> fi
Argh, there's a "--revs-only" thing that I was planning to use there, some
remnant of an ealy plan (unimplemented) to use that to determine if it is
a filename to be checked out, or a revision.
But then I never got around to do the "specify individual filenames" part
of "git checkout".
Anyway, add the --revs-only, and the test against empty should make a bit
more sense. In fact, it _should_ test that it's a SHA1 (and not a rev
argument), but I couldn't come up with a good way to test that in shell.
Linus
next prev parent reply other threads:[~2005-06-24 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-24 12:24 rev-parse, unknown arguments and extended sha1's Sven Verdoolaege
2005-06-24 16:09 ` Linus Torvalds [this message]
2005-06-24 16:17 ` Sven Verdoolaege
2005-06-24 16:43 ` Linus Torvalds
2005-06-24 17:32 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0506240904240.11175@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox