From: Linus Torvalds <torvalds@osdl.org>
To: Sven Verdoolaege <skimo@liacs.nl>
Cc: git@vger.kernel.org
Subject: Re: rev-parse, unknown arguments and extended sha1's
Date: Fri, 24 Jun 2005 09:43:12 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0506240941520.11175@ppc970.osdl.org> (raw)
In-Reply-To: <20050624161718.GA14909@pc117b.liacs.nl>
On Fri, 24 Jun 2005, Sven Verdoolaege wrote:
>
> This is what I use:
>
> rev2=`echo $rev | sed -e 's/[^0-9a-f]//'`
> rev3=`echo $rev2 | sed -e 's/........................................//'`
> if test "x$rev3" = "x" -a "x$rev" = "x$rev2"; then
> echo "valid SHA1"
> fi
Oooh. UGGHLEE.
This is one reason I don't do much shell.
Anyway, I think I'll make git-rev-parse have some option to "error out if
the result is anything but a single revision number", since this is really
the only reason for git-rev-parse in the first place: to make readable
scripts.
Linus
next prev parent reply other threads:[~2005-06-24 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-24 12:24 rev-parse, unknown arguments and extended sha1's Sven Verdoolaege
2005-06-24 16:09 ` Linus Torvalds
2005-06-24 16:17 ` Sven Verdoolaege
2005-06-24 16:43 ` Linus Torvalds [this message]
2005-06-24 17:32 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0506240941520.11175@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox