From: Colin Stagner <ask+git@howdoi.land>
To: Ian Jackson <ijackson@chiark.greenend.org.uk>
Cc: git@vger.kernel.org, Christian Heusel <christian@heusel.eu>,
george@mail.dietrich.pub, Christian Hesse <list@eworm.de>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/3] contrib/subtree: reduce recursion during split
Date: Thu, 16 Apr 2026 23:50:21 -0500 [thread overview]
Message-ID: <a1a07433-224e-4477-ae8a-3875fa98faf8@howdoi.land> (raw)
In-Reply-To: <27104.58166.993109.63505@chiark.greenend.org.uk>
On 4/16/26 08:25, Ian Jackson wrote:
> FTR Debian supports multiple options for /bin/sh. The shell in
> question, with the limit that's troubling us, is dash.
Correct, I experience this behavior in dash.
> Why not run the script under bash in non-POSIX mode instead? I think
> that would sidestep the problem.
Our coding guidelines favor POSIX constructs over non-POSIX constructs,
including for shell scripts [1]. POSIX helps us stay portable.
I'm not convinced that adding more shell interpreters to the mix would
be a net win in terms of stability or consistency. This patch series
addresses issues that arise from different implementations of sh. Adding
bash vs sh to the mix will probably just make more bugs.
> If it had been me I would probably have used Rust and libgit2.
git-subtree has been around since 2009, so you would have first needed
to invent Rust. :-) That said, a native Rust version of
git-subtree-split would be much faster and easier to read.
Thanks for looking at this,
Colin
[1]: https://git-scm.com/docs/CodingGuidelines
next prev parent reply other threads:[~2026-04-17 4:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 20:17 [PATCH 0/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-02-15 20:17 ` [PATCH 1/3] contrib/subtree: reduce function side-effects Colin Stagner
2026-02-15 20:17 ` [PATCH 2/3] contrib/subtree: functionalize split traversal Colin Stagner
2026-02-15 20:17 ` [PATCH 3/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-03-05 23:55 ` [PATCH v2 0/3] " Colin Stagner
2026-03-05 23:55 ` [PATCH v2 1/3] contrib/subtree: reduce function side-effects Colin Stagner
2026-03-05 23:55 ` [PATCH v2 2/3] contrib/subtree: functionalize split traversal Colin Stagner
2026-03-05 23:55 ` [PATCH v2 3/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-03-13 22:51 ` [PATCH v2 0/3] " Junio C Hamano
2026-03-13 23:06 ` Junio C Hamano
2026-04-15 17:58 ` Junio C Hamano
2026-04-15 21:39 ` Ben Knoble
2026-04-16 13:25 ` Ian Jackson
2026-04-16 19:34 ` Junio C Hamano
2026-04-17 4:50 ` Colin Stagner [this message]
2026-04-19 19:55 ` Ian Jackson
2026-04-20 1:09 ` Ben Knoble
2026-04-20 1:50 ` Junio C Hamano
2026-04-20 9:57 ` Ian Jackson
2026-04-21 5:07 ` Colin Stagner
2026-04-22 9:43 ` Johannes Schindelin
2026-04-22 17:12 ` git-subtree rewrite Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a07433-224e-4477-ae8a-3875fa98faf8@howdoi.land \
--to=ask+git@howdoi.land \
--cc=christian@heusel.eu \
--cc=george@mail.dietrich.pub \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ijackson@chiark.greenend.org.uk \
--cc=list@eworm.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox