From: Junio C Hamano <gitster@pobox.com>
To: Ian Jackson <ijackson@chiark.greenend.org.uk>
Cc: Colin Stagner <ask+git@howdoi.land>,
git@vger.kernel.org, Christian Heusel <christian@heusel.eu>,
george@mail.dietrich.pub, Christian Hesse <list@eworm.de>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2 0/3] contrib/subtree: reduce recursion during split
Date: Sun, 19 Apr 2026 18:50:42 -0700 [thread overview]
Message-ID: <xmqqa4uyv1ql.fsf@gitster.g> (raw)
In-Reply-To: <27109.13129.424068.382997@chiark.greenend.org.uk> (Ian Jackson's message of "Sun, 19 Apr 2026 20:55:53 +0100")
Ian Jackson <ijackson@chiark.greenend.org.uk> writes:
> Colin Stagner writes ("Re: [PATCH v2 0/3] contrib/subtree: reduce recursion during split"):
>> That said, a native Rust version of
>> git-subtree-split would be much faster and easier to read.
>
> I prototyped something along the lines of the algorithm I described
> earlier. It is very fast, as expected.
>
> The output looks plausible when I look at it by eye, but there are
> some things that I need to look at more closely. I should think some
> more about invariants and tests.
>
> Overall, I think this is worth pursuing.
;-).
> Before I go much further, how do we think this would best be packaged?
My preference is (as it has always been)
(1) host it somewhere outside of my tree,
(2) replace contrib/subtree/* with a single file
contrib/subtree/README that lead people to the new location.
The preference is not limited to subtree but generally applies to
things in contrib/. I prefer to see them graduate this project and
stand on their own, when they do not have storng dependency on the
git-core project. From technical point of view, this is especially
true if your plan is to depend on libgit2, as it is not our
dependency. Back when Git was very young, it did make sense to have
related-but-not-quite-Git things (like gitk and git-gui) shipped to
give them visibility, but we have passed that stage 15 years ago.
Thanks.
next prev parent reply other threads:[~2026-04-20 1:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 20:17 [PATCH 0/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-02-15 20:17 ` [PATCH 1/3] contrib/subtree: reduce function side-effects Colin Stagner
2026-02-15 20:17 ` [PATCH 2/3] contrib/subtree: functionalize split traversal Colin Stagner
2026-02-15 20:17 ` [PATCH 3/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-03-05 23:55 ` [PATCH v2 0/3] " Colin Stagner
2026-03-05 23:55 ` [PATCH v2 1/3] contrib/subtree: reduce function side-effects Colin Stagner
2026-03-05 23:55 ` [PATCH v2 2/3] contrib/subtree: functionalize split traversal Colin Stagner
2026-03-05 23:55 ` [PATCH v2 3/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-03-13 22:51 ` [PATCH v2 0/3] " Junio C Hamano
2026-03-13 23:06 ` Junio C Hamano
2026-04-15 17:58 ` Junio C Hamano
2026-04-15 21:39 ` Ben Knoble
2026-04-16 13:25 ` Ian Jackson
2026-04-16 19:34 ` Junio C Hamano
2026-04-17 4:50 ` Colin Stagner
2026-04-19 19:55 ` Ian Jackson
2026-04-20 1:09 ` Ben Knoble
2026-04-20 1:50 ` Junio C Hamano [this message]
2026-04-20 9:57 ` Ian Jackson
2026-04-21 5:07 ` Colin Stagner
2026-04-22 9:43 ` Johannes Schindelin
2026-04-22 17:12 ` git-subtree rewrite Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa4uyv1ql.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ask+git@howdoi.land \
--cc=christian@heusel.eu \
--cc=george@mail.dietrich.pub \
--cc=git@vger.kernel.org \
--cc=ijackson@chiark.greenend.org.uk \
--cc=list@eworm.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox