* [PATCH] test-lib: fix typo in test summary message
@ 2026-05-25 5:36 Amogh
2026-06-01 8:12 ` Patrick Steinhardt
0 siblings, 1 reply; 2+ messages in thread
From: Amogh @ 2026-05-25 5:36 UTC (permalink / raw)
To: git; +Cc: Amogh
There's a small typo ("passin", should be "passing") in the
summary/description message for t0000-basic. Even though this isn't a
user-facing string it should improve the developer experience + reduce
confusion when working on the codebase.
---
t/t0000-basic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 2b63e1c86c..9f6991a9ab 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -141,7 +141,7 @@ test_expect_success 'subtest: a passing TODO test' '
EOF
'
-test_expect_success 'subtest: 2 TODO tests, one passin' '
+test_expect_success 'subtest: 2 TODO tests, one passing' '
write_and_run_sub_test_lib_test_err partially-passing-todos <<-\EOF &&
test_expect_failure "pretend we have a known breakage" "false"
test_expect_success "pretend we have a passing test" "true"
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] test-lib: fix typo in test summary message
2026-05-25 5:36 [PATCH] test-lib: fix typo in test summary message Amogh
@ 2026-06-01 8:12 ` Patrick Steinhardt
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Steinhardt @ 2026-06-01 8:12 UTC (permalink / raw)
To: Amogh; +Cc: git
On Sun, May 24, 2026 at 10:36:33PM -0700, Amogh wrote:
> There's a small typo ("passin", should be "passing") in the
> summary/description message for t0000-basic. Even though this isn't a
> user-facing string it should improve the developer experience + reduce
> confusion when working on the codebase.
I'd be surprised if this actually causes any confusion, so I feel like
the explanation is a bit lofty. But ultimately, one less typo is a good
thing, so the change makes sense to me.
Your patch is missing the "Signed-off-by:" trailer though.
Thanks!
Patrick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-01 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-25 5:36 [PATCH] test-lib: fix typo in test summary message Amogh
2026-06-01 8:12 ` Patrick Steinhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox