Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH 2/6] SubmittingPatches: discuss non-ident trailers
Date: Fri, 12 Jun 2026 13:35:47 +0200	[thread overview]
Message-ID: <aivvE6gVMGWhRbCB@pks.im> (raw)
In-Reply-To: <non-ident_trailers.8f5@msgid.xyz>

On Thu, Jun 11, 2026 at 12:22:45AM +0200, kristofferhaugsbakk@fastmail.com wrote:
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 0b12badf86d..51c308a89a8 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -474,7 +474,10 @@ These are the common trailers in use:
>  
>  While you can also create your own trailer if the situation warrants it, we
>  encourage you to instead use one of the common trailers in this project
> -highlighted above.
> +highlighted above. A trailer that credits someone might be more likely
> +to be accepted since these are the most common ones. But another kind of
> +trailer might be relevant, for example to link to an issue tracker
> +belonging to a downstream project that is affected by a bug in Git.

Hm, I wonder whether this is a bit too vague to really be helpful for a
newcomer. Instead of alluding to such trailers, wouldn't it be
preferable if we added those as actual examples to the list of known
trailers and then tell folks that they can invent their own ones if
there is a good reason to do so?

Patrick

  reply	other threads:[~2026-06-12 11:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 22:22 [PATCH 0/6] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-11 16:44   ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 2/6] SubmittingPatches: discuss non-ident trailers kristofferhaugsbakk
2026-06-12 11:35   ` Patrick Steinhardt [this message]
2026-06-10 22:22 ` [PATCH 3/6] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-11 16:46   ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-11 16:52   ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 5/6] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 6/6] SubmittingPatches: note that trailer order matters kristofferhaugsbakk
2026-06-10 22:30   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aivvE6gVMGWhRbCB@pks.im \
    --to=ps@pks.im \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox