From: Patrick Steinhardt <ps@pks.im>
To: Weijie Yuan <wy@wyuan.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v3 0/2] doc: clarify review replies and reroll timing
Date: Wed, 24 Jun 2026 13:47:05 +0200 [thread overview]
Message-ID: <ajvDuUiDsmyf5LnX@pks.im> (raw)
In-Reply-To: <cover.1782028813.git.wy@wyuan.org>
On Sun, Jun 21, 2026 at 04:04:36PM +0800, Weijie Yuan wrote:
> Changes in v3:
>
> - Reworked the substantial-rework case. Instead of suggesting that
> authors send a new version sooner, the text now advises authors not
> to rush out an updated version before reviewing the larger changes
> carefully. It recommends replying to the review that prompted the
> rewrite, saying that a substantial rework is planned, and pointing
> out which parts of the current series will become obsolete.
>
> - Dropped the advice that a topic close to being accepted may justify
> a quicker reroll.
>
> - Removed "how close the topic is to being accepted" from the short
> reroll-timing guidance in Documentation/SubmittingPatches.
>
> - Updated the commit message of patch 2 accordingly.
I'm happy with this version, thanks!
Patrick
prev parent reply other threads:[~2026-06-24 11:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 14:08 [RFC PATCH 0/2] doc: clarify review replies and reroll timing Weijie Yuan
2026-06-13 14:08 ` [RFC PATCH 1/2] doc: encourage review replies before rerolling Weijie Yuan
2026-06-15 13:17 ` Patrick Steinhardt
2026-06-15 14:35 ` Weijie Yuan
2026-06-13 14:09 ` [RFC PATCH 2/2] doc: advise batching patch rerolls Weijie Yuan
2026-06-13 16:02 ` Junio C Hamano
2026-06-13 17:05 ` Weijie Yuan
2026-06-15 13:17 ` Patrick Steinhardt
2026-06-15 14:49 ` Weijie Yuan
2026-06-17 16:48 ` [PATCH v2 0/2] doc: clarify review replies and reroll timing Weijie Yuan
2026-06-17 16:50 ` [PATCH v2 1/2] doc: encourage review replies before rerolling Weijie Yuan
2026-06-17 16:51 ` [PATCH v2 2/2] doc: advise batching patch rerolls Weijie Yuan
2026-06-17 17:50 ` Junio C Hamano
2026-06-19 13:20 ` Weijie Yuan
2026-06-24 11:46 ` Patrick Steinhardt
2026-06-21 8:04 ` [PATCH v3 0/2] doc: clarify review replies and reroll timing Weijie Yuan
2026-06-21 8:05 ` [PATCH v3 1/2] doc: encourage review replies before rerolling Weijie Yuan
2026-06-21 8:05 ` [PATCH v3 2/2] doc: advise batching patch rerolls Weijie Yuan
2026-06-24 11:46 ` Patrick Steinhardt
2026-06-24 11:47 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajvDuUiDsmyf5LnX@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wy@wyuan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox