Git development
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
	git@vger.kernel.org,  Konstantin Ryabitsev <mricon@kernel.org>
Subject: Re: [PATCH 00/11] sequencer: do not record dropped commits as rewritten
Date: Wed, 1 Jul 2026 08:00:48 +0200	[thread overview]
Message-ID: <akSqjIzdvsjK0yoM@monoceros> (raw)
In-Reply-To: <xmqqpl17rec3.fsf@gitster.g>

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

Hello,

On Tue, Jun 30, 2026 at 12:57:32PM -0700, Junio C Hamano wrote:
> A tangent (I Cc'ed Konstantin for this), but
> 
>     $ b4 am -o- '<cover.1782833268.git.phillip.wood@dunelm.org.uk>' >b4am.mbx
> 
> failed to produce a usable mailbox.  It somehow did not think [2/11]
> existed.

FTR: The mail is on lore.kernel.org.

Also to yield a usable mailbox my patch shouldn't be included.

> I manually examined the References and In-Reply-To headers
> of that particular message and compared them with those from other
> messages but did not find anything suspicious X-<.


> 
> I have a bunch of typofixes queued on top of these 11 patches (made
> with "git commit --fixup reword:<sha1>"); please double check when
> you reroll after seeing more substantial reviews than mere typofixes,
> possibly from others.
> 
> Thanks.
> 
> 
> Here is the transcript of failed b4 am invocation.
> ---- >8 ----
> Looking up https://lore.kernel.org/all/cover.1782833268.git.phillip.wood@dunelm.org.uk/
> Grabbing thread from lore.kernel.org/all/cover.1782833268.git.phillip.wood@dunelm.org.uk/t.mbox.gz
> Analyzing 17 messages in the thread
> WARNING: duplicate messages found at index 1
>    Subject 1: sequencer: Skip copying notes for commits that disappear during rebase
>    Subject 2: t3400: restore coverage for note copying with apply backend
>   2 is not a reply... assume additional patch

I think here is the origin of the problem. It guesses that the t3400
should be added, and it takes the place of Phillip's second patch.

>   ERROR: missing [12/2]!

This is irritating, I would have expected "[2/12]" here?

	b4 am --no-parent cover.1782833268.git.phillip.wood@dunelm.org.uk

works fine for me.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-07-01  6:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 17:40 [PATCH] sequencer: Skip copying notes for commits that disappear during rebase Uwe Kleine-König
2026-06-17 13:24 ` Junio C Hamano
2026-06-17 13:58   ` Uwe Kleine-König
2026-06-19 10:13     ` Phillip Wood
2026-06-19 13:01       ` Uwe Kleine-König
2026-06-30 15:28       ` [PATCH 00/11] sequencer: do not record dropped commits as rewritten Phillip Wood
2026-06-30 15:28         ` [PATCH 01/11] t3400: restore coverage for note copying with apply backend Phillip Wood
2026-06-30 15:28         ` [PATCH 02/11] sequencer: move definition of is_final_fixup() Phillip Wood
2026-06-30 15:28         ` [PATCH 03/11] sequencer: be more careful with external merge Phillip Wood
2026-06-30 15:28         ` [PATCH 04/11] sequencer: never reschedule on failed commit Phillip Wood
2026-06-30 15:28         ` [PATCH 05/11] sequencer: remove unnecessary "or" in pick_one_commit() Phillip Wood
2026-06-30 15:28         ` [PATCH 06/11] sequencer: simplify handing of fixup with conflicts Phillip Wood
2026-06-30 15:28         ` [PATCH 07/11] sequencer: remove unnecessary condition in pick_one_commit() Phillip Wood
2026-06-30 15:28         ` [PATCH 08/11] sequencer: simplify pick_one_commit() Phillip Wood
2026-07-06 11:06           ` Oswald Buddenhagen
2026-07-06 13:40             ` Phillip Wood
2026-06-30 15:28         ` [PATCH 09/11] sequencer: return early from pick_one_commit() on success Phillip Wood
2026-07-06 11:08           ` Oswald Buddenhagen
2026-06-30 15:29         ` [PATCH 10/11] sequencer: use an enum to represent result of picking a commit Phillip Wood
2026-07-06 11:12           ` Oswald Buddenhagen
2026-07-06 13:39             ` Phillip Wood
2026-06-30 15:29         ` [PATCH 11/11] sequencer: do not record dropped commits as rewritten Phillip Wood
2026-06-30 19:57         ` [PATCH 00/11] " Junio C Hamano
2026-07-01  6:00           ` Uwe Kleine-König [this message]
2026-07-01 13:29             ` Phillip Wood
2026-07-01 13:31           ` Phillip Wood
2026-07-01  9:38         ` Uwe Kleine-König
2026-07-01 13:37           ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akSqjIzdvsjK0yoM@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mricon@kernel.org \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox