Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE`
Date: Thu, 16 Jul 2026 07:32:23 +0200	[thread overview]
Message-ID: <alhs5wDFGWbzp2Zs@pks.im> (raw)
In-Reply-To: <871pd4h1y3.fsf@emacs.iotcl.com>

On Wed, Jul 15, 2026 at 02:28:20PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > There's a single user of `the_repository` in the "packed" reference
> > backend. Convert it to instead use the backend's repository and drop
> > `USE_THE_REPOSITORY_VARIABLE`.
> 
> Well, this was removed in the previous patch. I'm fine keeping this as a
> separate commmit, but the messaging is a bit confusing.

That's fair indeed. I don't quite remember why I split it up -- I assume
that originally I had to do some more changes? Anyway, I think it's
sensible to just merge these two commits.

Patrick

  reply	other threads:[~2026-07-16  5:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  8:29 [PATCH 0/7] refs: remove use of `the_repository` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 1/7] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-09 18:52   ` Junio C Hamano
2026-07-10  5:56     ` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 3/7] refs/files: " Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 4/7] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 5/7] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 6/7] worktree: pass repository to public functions Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 7/7] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-09 20:39 ` [PATCH 0/7] refs: remove use " Junio C Hamano
2026-07-10  5:56   ` Patrick Steinhardt
2026-07-10  6:14     ` Patrick Steinhardt
2026-07-10 16:57       ` Junio C Hamano
2026-07-10 20:24         ` Junio C Hamano
2026-07-10 14:48     ` Junio C Hamano
2026-07-15  7:39 ` [PATCH v2 " Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 1/7] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-15 12:28     ` Toon Claes
2026-07-16  5:32       ` Patrick Steinhardt [this message]
2026-07-15  7:39   ` [PATCH v2 3/7] refs/files: " Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 4/7] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 5/7] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 6/7] worktree: pass repository to public functions Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 7/7] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-15 12:31   ` [PATCH v2 0/7] refs: remove use " Toon Claes
2026-07-15 14:38     ` Junio C Hamano
2026-07-16  5:33 ` [PATCH v3 0/6] " Patrick Steinhardt
2026-07-16  5:33   ` [PATCH v3 1/6] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-16  5:33   ` [PATCH v3 2/6] refs/files: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-16  5:33   ` [PATCH v3 3/6] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-16  5:33   ` [PATCH v3 4/6] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-16  5:33   ` [PATCH v3 5/6] worktree: pass repository to public functions Patrick Steinhardt
2026-07-16  5:33   ` [PATCH v3 6/6] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-16  6:53   ` [PATCH v3 0/6] refs: remove use " Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alhs5wDFGWbzp2Zs@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox