Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/6] MyFirstContribution: what if I don't get a reply?
Date: Fri, 17 Jul 2026 13:12:03 +0200	[thread overview]
Message-ID: <aloOAwOtutgPbJu2@pks.im> (raw)
In-Reply-To: <20260711192650.2417665-3-gitster@pobox.com>

On Sat, Jul 11, 2026 at 12:26:46PM -0700, Junio C Hamano wrote:
> Tell readers that pinging is a perfectly sensible thing to do when
> they do not see a response.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Documentation/MyFirstContribution.adoc | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 4832e5bad5..fc2ce2e785 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1438,6 +1438,19 @@ substantial rework, and mention which parts of the current series will become
>  obsolete so reviewers can avoid spending time on them until the updated series
>  is ready.
>  
> +=== What if I don't get a reply?
> +
> +If you don't receive any review comments after a week or two, do not
> +assume your patch has been accepted or merged.  In the Git project,
> +silence does not equal approval.  It usually means reviewers are busy
> +or haven't noticed your contribution.

Should we also add the third reason: reviewers are simply not interested
in the patch? It's a bit brutal, but that's quite a common reason, too.
In the best case we'd of course tell the submitter that we don't want
the patch to not leave them hanging.

> +If your patch is overlooked, it is perfectly acceptable to send a
> +polite ping to the thread.  You can do this by replying to your own
> +cover letter (or patch) to ask if anyone has had a chance to look at
> +it.  You can also CC additional people who might be interested; use
> +the `git-contacts` script (mentioned earlier) to find relevant contributors.

And this paragraph here can remain as-is regardless of which of the
three reasons applies.

Patrick

  reply	other threads:[~2026-07-17 11:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-11 19:26 [PATCH 0/6] Update Contributor Guides Junio C Hamano
2026-07-11 19:26 ` [PATCH 1/6] SubmittingPatches: clarify expected structure of commit log message Junio C Hamano
2026-07-12 14:49   ` Weijie Yuan
2026-07-12 16:07     ` Junio C Hamano
2026-07-13 14:14       ` Weijie Yuan
2026-07-12 20:26   ` Michael Montalbo
2026-07-13  0:07     ` Junio C Hamano
2026-07-13 14:14       ` Weijie Yuan
2026-07-14 22:46         ` D. Ben Knoble
2026-07-17 12:42           ` Weijie Yuan
2026-07-11 19:26 ` [PATCH 2/6] MyFirstContribution: what if I don't get a reply? Junio C Hamano
2026-07-17 11:12   ` Patrick Steinhardt [this message]
2026-07-11 19:26 ` [PATCH 3/6] MyFirstContribution: carrying over trailers Junio C Hamano
2026-07-11 19:26 ` [PATCH 4/6] MyFirstContribution: clarify that 'seen' does not mean acceptance Junio C Hamano
2026-07-12 18:08   ` Matt Hunter
2026-07-12 19:04     ` Junio C Hamano
2026-07-11 19:26 ` [PATCH 5/6] SubmittingPatches: clarify the meaning of "Will queue" Junio C Hamano
2026-07-11 19:26 ` [PATCH 6/6] SubmittingPatches: clarify the writing style of whats-cooking Junio C Hamano
2026-07-12 20:41   ` Michael Montalbo
2026-07-13  4:20     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aloOAwOtutgPbJu2@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox