Git development
 help / color / mirror / Atom feed
From: Weijie Yuan <wy@wyuan.org>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Michael Montalbo <mmontalbo@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/6] SubmittingPatches: clarify expected structure of commit log message
Date: Fri, 17 Jul 2026 20:42:53 +0800	[thread overview]
Message-ID: <alojTem4a5q1Xu4X@wyuan.org> (raw)
In-Reply-To: <CALnO6CD8HFWaeN-4Gccopy0nw601cMyak_LSXfTsAa8xwOjKpQ@mail.gmail.com>

On Tue, Jul 14, 2026 at 06:46:05PM -0400, D. Ben Knoble wrote:
> On Mon, Jul 13, 2026 at 10:42 AM Weijie Yuan <wy@wyuan.org> wrote:
> >
> [snip]
> > I think this might confuse readers. Now you place these points in
> > parallel:
> >
> >  1. Title
> >  2. Body
> >  3. Observation (The Status Quo)
> >  4. Solution Design (The Approach)
> >  5. Implementation (The Execution)
> 
> Without commenting on "confuse," I find this style of heading
> 
>     Thing (The Other Thing)
> 
> needlessly suggests an LLM's involvement with the text.

Aha, kind of. But I guess Junio didn't use LLM here ;-)

> That by itself is not grounds for my objection; instead, I'll note
> that often the parenthetical restates the original header in some way.
> That makes it redundant. (In some cases in the wild I have seen
> examples where the 2 were not synonymous, which _is_ confusing :)

True.

> > But acatually you mean:
> >
> > 1. Title
> > 2. Body
> >    The body typically follows three parts:
> >    a. Observation
> >    b. Solution Design
> >    c. Implementation
> >
> > But I haven't written much about adoc, so I don't know its syntax and
> > how to write it.
> 
> This is nice. If I had to suggest anything further, it would be "don't
> be afraid of long headings":
> 
> 1. Title: Summarize the change
> 2. Body: Describe [Justify?] the change
>     a. Observe the status quo
>     b. Explain your approach [solution/design/etc.]
>     c. Command the code to change [or: Describe the implementation/execution]
> 
> ?

I agree. More explanatory descriptions here are very likely to enable
contributors to express their ideas more clearly and understandably.

  reply	other threads:[~2026-07-17 12:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-11 19:26 [PATCH 0/6] Update Contributor Guides Junio C Hamano
2026-07-11 19:26 ` [PATCH 1/6] SubmittingPatches: clarify expected structure of commit log message Junio C Hamano
2026-07-12 14:49   ` Weijie Yuan
2026-07-12 16:07     ` Junio C Hamano
2026-07-13 14:14       ` Weijie Yuan
2026-07-12 20:26   ` Michael Montalbo
2026-07-13  0:07     ` Junio C Hamano
2026-07-13 14:14       ` Weijie Yuan
2026-07-14 22:46         ` D. Ben Knoble
2026-07-17 12:42           ` Weijie Yuan [this message]
2026-07-11 19:26 ` [PATCH 2/6] MyFirstContribution: what if I don't get a reply? Junio C Hamano
2026-07-17 11:12   ` Patrick Steinhardt
2026-07-11 19:26 ` [PATCH 3/6] MyFirstContribution: carrying over trailers Junio C Hamano
2026-07-11 19:26 ` [PATCH 4/6] MyFirstContribution: clarify that 'seen' does not mean acceptance Junio C Hamano
2026-07-12 18:08   ` Matt Hunter
2026-07-12 19:04     ` Junio C Hamano
2026-07-11 19:26 ` [PATCH 5/6] SubmittingPatches: clarify the meaning of "Will queue" Junio C Hamano
2026-07-11 19:26 ` [PATCH 6/6] SubmittingPatches: clarify the writing style of whats-cooking Junio C Hamano
2026-07-12 20:41   ` Michael Montalbo
2026-07-13  4:20     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alojTem4a5q1Xu4X@wyuan.org \
    --to=wy@wyuan.org \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mmontalbo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox