From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH] git-daemon: fix for rotating logs
Date: Mon, 28 Apr 2008 15:24:07 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0804281523040.5399@eeepc-johanness> (raw)
With rotating logs, there is a problem when the syslog is opened only once
(in the beginning). So open the log everytime we write something, and
close it directly after writing.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
daemon.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/daemon.c b/daemon.c
index 2b4a6f1..a887c72 100644
--- a/daemon.c
+++ b/daemon.c
@@ -90,7 +90,9 @@ static void logreport(int priority, const char *err, va_list params)
msglen = vsnprintf(buf + buflen, maxlen, err, params);
if (log_syslog) {
+ openlog("git-daemon", 0, LOG_DAEMON);
syslog(priority, "%s", buf);
+ closelog();
return;
}
@@ -767,8 +769,11 @@ static void child_handler(int signo)
const char *dead = "";
if (!WIFEXITED(status) || WEXITSTATUS(status) > 0)
dead = " (with error)";
- if (log_syslog)
+ if (log_syslog) {
+ openlog("git-daemon", 0, LOG_DAEMON);
syslog(LOG_INFO, "[%d] Disconnected%s", pid, dead);
+ closelog();
+ }
else
fprintf(stderr, "[%d] Disconnected%s\n", pid, dead);
}
@@ -1149,10 +1154,8 @@ int main(int argc, char **argv)
usage(daemon_usage);
}
- if (log_syslog) {
- openlog("git-daemon", 0, LOG_DAEMON);
+ if (log_syslog)
set_die_routine(daemon_die);
- }
if (inetd_mode && (group_name || user_name))
die("--user and --group are incompatible with --inetd");
--
1.5.4.4.GIT
next reply other threads:[~2008-04-28 14:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 14:24 Johannes Schindelin [this message]
2008-04-28 16:29 ` [PATCH] git-daemon: fix for rotating logs Junio C Hamano
2008-04-28 18:08 ` Johannes Schindelin
2008-04-28 18:21 ` Miklos Vajna
2008-04-28 18:29 ` Mike Hommey
2008-04-28 18:37 ` Johannes Schindelin
2008-04-28 19:00 ` Miklos Vajna
2008-04-28 19:24 ` Johannes Schindelin
2008-04-28 19:28 ` Stephen R. van den Berg
2008-04-28 19:53 ` Johannes Schindelin
2008-04-28 20:43 ` Stephen R. van den Berg
2008-04-28 20:53 ` Johannes Schindelin
2008-04-28 21:00 ` Stephen R. van den Berg
2008-04-28 21:09 ` Johannes Schindelin
2008-04-28 21:13 ` Stephen R. van den Berg
2008-04-28 21:23 ` Johannes Schindelin
2008-04-28 23:16 ` Stephen R. van den Berg
2008-04-29 6:17 ` Andreas Ericsson
2008-04-29 10:54 ` Johannes Schindelin
2008-04-29 11:00 ` Andreas Ericsson
2008-04-29 15:16 ` Johannes Schindelin
2008-04-29 17:58 ` Stephen R. van den Berg
2008-05-11 18:03 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0804281523040.5399@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox