From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-daemon: fix for rotating logs
Date: Sun, 11 May 2008 19:03:42 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0805111901390.30431@racer> (raw)
In-Reply-To: <alpine.DEB.1.00.0804281523040.5399@eeepc-johanness>
Hi,
On Mon, 28 Apr 2008, Johannes Schindelin wrote:
> With rotating logs, there is a problem when the syslog is opened only
> once (in the beginning). So open the log everytime we write something,
> and close it directly after writing.
Actually, the culprit were _not_ rotating logs. At least not really.
syslog() is not supposed to be called from a signal handler. In
git-daemon, it is, from child_handler(), but only when called with
--verbose (and --syslog, or --detach). Bummer.
Sorry for my wrong analysis,
Dscho
prev parent reply other threads:[~2008-05-11 18:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 14:24 [PATCH] git-daemon: fix for rotating logs Johannes Schindelin
2008-04-28 16:29 ` Junio C Hamano
2008-04-28 18:08 ` Johannes Schindelin
2008-04-28 18:21 ` Miklos Vajna
2008-04-28 18:29 ` Mike Hommey
2008-04-28 18:37 ` Johannes Schindelin
2008-04-28 19:00 ` Miklos Vajna
2008-04-28 19:24 ` Johannes Schindelin
2008-04-28 19:28 ` Stephen R. van den Berg
2008-04-28 19:53 ` Johannes Schindelin
2008-04-28 20:43 ` Stephen R. van den Berg
2008-04-28 20:53 ` Johannes Schindelin
2008-04-28 21:00 ` Stephen R. van den Berg
2008-04-28 21:09 ` Johannes Schindelin
2008-04-28 21:13 ` Stephen R. van den Berg
2008-04-28 21:23 ` Johannes Schindelin
2008-04-28 23:16 ` Stephen R. van den Berg
2008-04-29 6:17 ` Andreas Ericsson
2008-04-29 10:54 ` Johannes Schindelin
2008-04-29 11:00 ` Andreas Ericsson
2008-04-29 15:16 ` Johannes Schindelin
2008-04-29 17:58 ` Stephen R. van den Berg
2008-05-11 18:03 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0805111901390.30431@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox