From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Jörg Sommer" <joerg@alea.gnuu.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Pay attention to GIT_DIR when searching the git directory
Date: Mon, 5 May 2008 14:39:46 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0805051437040.30431@racer> (raw)
In-Reply-To: <20080505125302.GA11523@alea.gnuu.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 754 bytes --]
Hi,
On Mon, 5 May 2008, Jörg Sommer wrote:
> Johannes Schindelin schrieb am Mon 05. May, 12:36 (+0100):
>
> > Please keep in mind that the commit log is meant to demonstrate the
> > _intention_ of the patches.
>
> The intention is that the variable GIT_DIR is respected when searching
> for the git dir.
AFAICT the core of git respects GIT_DIR very much. Reading your oneline,
indeed, the whole commit message, scared me a bit, because I thought that
there was a bug in core git.
Your commit message completely misses out on the fact that it fixes a bug
in a _hook_, and a _contributed_ at that.
So I would have known _exactly_ what you did if your oneline had read
contrib/hooks/setgitperms: respect GIT_DIR
Don't you agree?
Ciao,
Dscho
next prev parent reply other threads:[~2008-05-05 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 0:09 [PATCH] Pay attention to GIT_DIR when searching the git directory Jörg Sommer
2008-05-05 11:36 ` Johannes Schindelin
2008-05-05 12:53 ` Jörg Sommer
2008-05-05 13:39 ` Johannes Schindelin [this message]
2008-05-05 14:10 ` Jakub Narebski
2008-05-05 15:30 ` Jörg Sommer
2008-05-05 16:33 ` Johannes Schindelin
2008-05-05 16:48 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0805051437040.30431@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=joerg@alea.gnuu.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox