Re: [PATCH] Pay attention to GIT_DIR when searching the git directory

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1205 bytes --]

Hi,

On Mon, 5 May 2008, Jörg Sommer wrote:

> Hi Jakub,
> 
> Jakub Narebski schrieb am Mon 05. May, 07:10 (-0700):
> > Jörg Sommer <joerg@alea.gnuu.de> writes:
> > > Johannes Schindelin schrieb am Mon 05. May, 12:36 (+0100):
> > 
> > > > If you do not say _what_ is affected by the change, you only 
> > > > confuse the readers.
> > > 
> > > Do you want something like “initialization: Pay attention to GIT_DIR 
> > > when searching the git directory”?
> > 
> > I think the idea was to use
> >   "contrib/hooks/setgitperms: Use GIT_DIR if set"
> > or something like that.
> 
> Well, if this is the prefered form, I'll use it. But I don't like it,
> because the affected file is a piece of information that's already in the
> commit object.

Well, I don't like that you thereby waste the time of those who look at 
the commit message.  By your reasoning, one might think that commit 
messages are superfluous, because you can always read the patch, or go 
back to the mailing list thread.

Ciao,
Dscho
> > There are a few unwritten conventions.
> 
> Are there any plans to write them down?

Actually, they are written down implicitly.  You can look at them with the 
command "git log".

Ciao,
Dscho