From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Git Mailinglist <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig
Date: Fri, 27 Jun 2008 13:55:23 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806271353350.9925@racer> (raw)
In-Reply-To: <27C25D70-0BFC-4362-A771-C7CAD89BC198@ai.rug.nl>
After initializing the config in the newly-created repository, we
need to unset GIT_CONFIG so that the global configs are read again.
Noticed by Pieter de Bie.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Fri, 27 Jun 2008, Pieter de Bie wrote:
> I sometimes use url.insteadOf to create a shortcut to a central
> repository. For example, having something like[*1*]
>
> [url "git://repo.or.cz/git/"]
> insteadOf = "repo:"
>
> in my global gitconfig allows me to do a 'git fetch
> repo:dscho.git'. I'd also like to use that with git clone :).
> Currently if I try that, I get
>
> Vienna:~ pieter$ git clone repo:dscho.git
> Initialize dscho/.git
> Initialized empty Git repository in /Users/pieter/dscho/.git/
> ssh: Error resolving hostname repo: nodename nor servname provided,
> or not known
> fatal: The remote end hung up unexpectedly
>
> [...]
>
> Is there an easy fix for this?
Yes ;-)
builtin-clone.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/builtin-clone.c b/builtin-clone.c
index 17baa20..965b5fc 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c
@@ -424,6 +424,13 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
fprintf(stderr, "Initialize %s\n", git_dir);
init_db(option_template, option_quiet ? INIT_DB_QUIET : 0);
+ /*
+ * At this point, the config exists, so we do not need the
+ * environment variable. We actually need to unset it, too, to
+ * re-enable parsing of the global configs.
+ */
+ unsetenv(CONFIG_ENVIRONMENT);
+
if (option_reference)
setup_reference(git_dir);
--
1.5.6.173.gde14c
next prev parent reply other threads:[~2008-06-27 12:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 9:35 Using url.insteadOf in git-clone Pieter de Bie
2008-06-27 12:55 ` Johannes Schindelin [this message]
2008-06-27 12:56 ` [PATCH 2/2] clone: respect url.insteadOf setting in global configs Johannes Schindelin
2008-06-27 16:08 ` Daniel Barkalow
2008-06-29 20:12 ` Pieter de Bie
2008-06-29 21:50 ` Johannes Schindelin
2008-06-27 16:05 ` [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig Daniel Barkalow
2008-06-27 22:40 ` Junio C Hamano
2008-06-29 18:31 ` Daniel Barkalow
2008-06-29 20:36 ` Junio C Hamano
2008-06-29 21:49 ` Johannes Schindelin
2008-06-29 22:47 ` Daniel Barkalow
2008-06-30 0:41 ` Johannes Schindelin
2008-06-30 1:54 ` Daniel Barkalow
2008-06-30 1:20 ` Junio C Hamano
2008-06-30 2:21 ` Daniel Barkalow
2008-06-30 3:47 ` Daniel Barkalow
2008-06-30 11:57 ` Johannes Schindelin
2008-06-30 16:47 ` Daniel Barkalow
2008-06-30 6:20 ` Junio C Hamano
2008-06-30 6:25 ` Junio C Hamano
2008-06-30 6:40 ` Jeff King
2008-06-30 6:44 ` Junio C Hamano
2008-06-30 11:37 ` Johannes Schindelin
2008-06-27 17:11 ` Using url.insteadOf in git-clone Junio C Hamano
2008-06-29 18:59 ` Pieter de Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806271353350.9925@racer \
--to=johannes.schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox