Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Pieter de Bie <pdebie@ai.rug.nl>,
	Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig
Date: Sun, 29 Jun 2008 22:49:42 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0806292248160.9925@racer> (raw)
In-Reply-To: <alpine.LNX.1.00.0806291359330.19665@iabervon.org>

Hi,

On Sun, 29 Jun 2008, Daniel Barkalow wrote:

> Did we even make a commitment on whether:
> 
> GIT_CONFIG=foo git clone bar
> 
> must ignore the environment variable, or simply doesn't necessarily obey 
> it?

I'd rather strongly argue that no matter what is the answer to this 
question, we _HAVE TO_ unsetenv() GIT_CONFIG at some stage, otherwise no 
.git/config will be written.

So, this is a NACK on your patch.

Ciao,
Dscho

  parent reply	other threads:[~2008-06-29 21:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27  9:35 Using url.insteadOf in git-clone Pieter de Bie
2008-06-27 12:55 ` [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig Johannes Schindelin
2008-06-27 12:56   ` [PATCH 2/2] clone: respect url.insteadOf setting in global configs Johannes Schindelin
2008-06-27 16:08     ` Daniel Barkalow
2008-06-29 20:12     ` Pieter de Bie
2008-06-29 21:50       ` Johannes Schindelin
2008-06-27 16:05   ` [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig Daniel Barkalow
2008-06-27 22:40     ` Junio C Hamano
2008-06-29 18:31       ` Daniel Barkalow
2008-06-29 20:36         ` Junio C Hamano
2008-06-29 21:49         ` Johannes Schindelin [this message]
2008-06-29 22:47           ` Daniel Barkalow
2008-06-30  0:41             ` Johannes Schindelin
2008-06-30  1:54               ` Daniel Barkalow
2008-06-30  1:20             ` Junio C Hamano
2008-06-30  2:21               ` Daniel Barkalow
2008-06-30  3:47               ` Daniel Barkalow
2008-06-30 11:57                 ` Johannes Schindelin
2008-06-30 16:47                   ` Daniel Barkalow
2008-06-30  6:20           ` Junio C Hamano
2008-06-30  6:25             ` Junio C Hamano
2008-06-30  6:40               ` Jeff King
2008-06-30  6:44                 ` Junio C Hamano
2008-06-30 11:37             ` Johannes Schindelin
2008-06-27 17:11 ` Using url.insteadOf in git-clone Junio C Hamano
2008-06-29 18:59   ` Pieter de Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0806292248160.9925@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pdebie@ai.rug.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox