From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-submodule - register module url if adding in place
Date: Tue, 8 Jul 2008 13:34:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807081332580.4319@eeepc-johanness> (raw)
In-Reply-To: <1215484630-3784-1-git-send-email-mlevedahl@gmail.com>
Hi,
On Mon, 7 Jul 2008, Mark Levedahl wrote:
> When adding a new submodule in place, meaning the user created the
> submodule as a git repo in the tree first, we don't go through git
> submodule init to register the module. Thus, the url is not stored in
> .git/config, and no git operation will ever do so. In this case, assume
> the url the user supplies to git add is the one that should be
> registered, and do so.
I agree with Sylvain here, namely that this is too dangerous. Imagine
this very valid scenario:
$ git clone <somewhere> abc
$ git submodule add abc
Bummer.
Yes, happened to me.
So I'd like this to be an error, not something that tries to be helpful,
when it clearly cannot be.
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-08 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 2:37 [PATCH] git-submodule - register module url if adding in place Mark Levedahl
2008-07-08 11:34 ` Johannes Schindelin [this message]
2008-07-08 23:59 ` Mark Levedahl
2008-07-09 0:11 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807081332580.4319@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox