From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-submodule - register module url if adding in place
Date: Wed, 9 Jul 2008 02:11:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807090210080.5277@eeepc-johanness> (raw)
In-Reply-To: <4873FF6E.2020602@gmail.com>
Hi,
On Tue, 8 Jul 2008, Mark Levedahl wrote:
> Johannes Schindelin wrote:
> > I agree with Sylvain here, namely that this is too dangerous.
> > Imagine this very valid scenario:
> >
> > $ git clone <somewhere> abc
> > $ git submodule add abc
> >
> > Bummer.
> >
> > Yes, happened to me.
> >
> > So I'd like this to be an error, not something that tries to be
> > helpful, when it clearly cannot be.
>
> I think the real issue here is that submodule-add is too flexible and
> poorly documented, see my response to Junio in the other thread.
In contrast, I think that we should either disallow the form without URL,
or get the URL automatically from the submodule's current branch's default
remote.
Ciao,
Dscho
prev parent reply other threads:[~2008-07-09 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 2:37 [PATCH] git-submodule - register module url if adding in place Mark Levedahl
2008-07-08 11:34 ` Johannes Schindelin
2008-07-08 23:59 ` Mark Levedahl
2008-07-09 0:11 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807090210080.5277@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox