* [PATCH] builtin-commit: Two trivial style-cleanups
@ 2008-07-22 20:40 Johannes Schindelin
0 siblings, 0 replies; only message in thread
From: Johannes Schindelin @ 2008-07-22 20:40 UTC (permalink / raw)
To: git, gitster
Pierre Habouzit noticed that two variables were not static which should
have been, and that adding "\n\n" is better than adding '\n' twice.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
This was in my queue for half an eternity.
Oh, and it _is_ meant for inclusion. On top of master.
builtin-commit.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 97e64de..7434797 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -68,8 +68,8 @@ static enum {
static char *cleanup_arg;
static int use_editor = 1, initial_commit, in_merge;
-const char *only_include_assumed;
-struct strbuf message;
+static const char *only_include_assumed;
+static struct strbuf message;
static int opt_parse_m(const struct option *opt, const char *arg, int unset)
{
@@ -78,8 +78,7 @@ static int opt_parse_m(const struct option *opt, const char *arg, int unset)
strbuf_setlen(buf, 0);
else {
strbuf_addstr(buf, arg);
- strbuf_addch(buf, '\n');
- strbuf_addch(buf, '\n');
+ strbuf_addstr(buf, "\n\n");
}
return 0;
}
--
1.6.0.rc0.22.gf2096d.dirty
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-07-22 20:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-22 20:40 [PATCH] builtin-commit: Two trivial style-cleanups Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox