From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: Strange untracked file behaviour
Date: Wed, 17 Dec 2008 06:09:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0812170605300.14632@racer> (raw)
In-Reply-To: <20081216232452.GV5691@genesis.frugalware.org>
Hi,
On Wed, 17 Dec 2008, Miklos Vajna wrote:
> Here is a copy of the udev repo I cloned some time ago:
>
> http://frugalware.org/~vmiklos/files/udev.tar.bz2
>
> I did not modify it, so I thought a simple 'git pull' can update it.
>
> $ git pull
> Updating 661a0be..b6626d0
> error: Untracked working tree file 'test/sys/class/misc/rtc/dev' would
> be removed by merge.
I just spent three hours narrowing it down to this test case (but now I
have to catch 3 hours of sleep):
-- snipsnap --
[PATCH] Miklos' testcase
Even if we would not handle symlink/directory conflicts gracefully (which
we do, though), those conflicts should not affect unchanged files at all,
especially not claiming that they are untracked.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
t/t1008-read-tree-sd.sh | 39 +++++++++++++++++++++++++++++++++++++++
1 files changed, 39 insertions(+), 0 deletions(-)
create mode 100644 t/t1008-read-tree-sd.sh
diff --git a/t/t1008-read-tree-sd.sh b/t/t1008-read-tree-sd.sh
new file mode 100644
index 0000000..4d74430
--- /dev/null
+++ b/t/t1008-read-tree-sd.sh
@@ -0,0 +1,39 @@
+#!/bin/sh
+#
+# Copyright (c) 2008 Johannes E. Schindelin
+#
+
+test_description='symlink/directory conflict'
+
+. ./test-lib.sh
+
+test_expect_success 'setup' '
+
+ mkdir -p alpha/beta/gamma &&
+ ln -s delta alpha/beta/gamma/epsilon &&
+ mkdir -p alpha/beta/theta &&
+ ln -s zeta alpha/beta/theta/eta &&
+ mkdir -p iota/kappa/lambda/ &&
+ : > iota/kappa/lambda/mu &&
+ git add . &&
+ test_tick &&
+ git commit -m initial &&
+
+ git rm -r alpha/beta/gamma &&
+ ln -s nu alpha/beta/gamma &&
+ git rm -r alpha/beta/theta &&
+ ln -s xi alpha/beta/theta &&
+ git add . &&
+ test_tick &&
+ git commit -m 2nd
+
+'
+
+test_expect_failure 'read-tree -u -m handles symlinks gracefully' '
+
+ git checkout -b side HEAD^ &&
+ git read-tree -u -m master
+
+'
+
+test_done
--
1.6.0.4.1189.g8876f
next prev parent reply other threads:[~2008-12-17 5:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 23:24 Strange untracked file behaviour Miklos Vajna
2008-12-17 5:09 ` Johannes Schindelin [this message]
2008-12-17 14:38 ` Miklos Vajna
-- strict thread matches above, loose matches on Subject: below --
2009-01-01 20:54 unpack-trees: fix D/F conflict bugs in verify_absent Clemens Buchacher
2009-01-01 20:54 ` [PATCH 1/3] unpack-trees: handle failure " Clemens Buchacher
2009-01-01 20:54 ` [PATCH 2/3] unpack-trees: fix path search bug " Clemens Buchacher
2009-01-01 20:54 ` [PATCH 3/3] unpack-trees: remove redundant path search " Clemens Buchacher
2009-01-06 8:19 ` Junio C Hamano
2009-01-02 21:59 ` [PATCH 2/3] unpack-trees: fix path search bug " Johannes Schindelin
2009-01-03 14:01 ` Miklos Vajna
2009-01-02 21:59 ` Johannes Schindelin
2009-01-03 10:39 ` Clemens Buchacher
2009-01-03 12:53 ` Johannes Schindelin
2009-01-04 10:01 ` Junio C Hamano
2009-01-04 20:01 ` Clemens Buchacher
2009-01-06 19:35 ` Johannes Schindelin
2011-01-13 2:24 ` [RFC/PATCH 0/2] unpack-trees: handle lstat failures " Jonathan Nieder
2011-01-13 2:26 ` [PATCH 1/2] unpack-trees: handle lstat failure for existing directory Jonathan Nieder
2011-01-13 4:37 ` Miles Bader
2011-01-13 5:38 ` Jonathan Nieder
2011-01-13 2:28 ` [PATCH 2/2] unpack-trees: handle lstat failure for existing file Jonathan Nieder
2011-01-13 20:20 ` [RFC/PATCH 0/2] unpack-trees: handle lstat failures in verify_absent Clemens Buchacher
2009-01-01 21:28 ` unpack-trees: fix D/F conflict bugs " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0812170605300.14632@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox