From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Clemens Buchacher <drizzd@aon.at>
Cc: git@vger.kernel.org, Miklos Vajna <vmiklos@frugalware.org>,
gitster@pobox.com
Subject: Re: [PATCH 2/3] unpack-trees: fix path search bug in verify_absent
Date: Fri, 2 Jan 2009 22:59:43 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0901022244240.27818@racer> (raw)
In-Reply-To: <1230843273-11056-3-git-send-email-drizzd@aon.at>
On Thu, 1 Jan 2009, Clemens Buchacher wrote:
> Commit 0cf73755 (unpack-trees.c: assume submodules are clean during
> check-out) changed an argument to verify_absent from 'path' to 'ce',
> which is however shadowed by a local variable of the same name.
>
> The bug triggers if verify_absent is used on a tree entry, for which
> the index contains one or more subsequent directories of the same
> length. The affected subdirectories are removed from the index. The
> testcase included in this commit bisects to 55218834 (checkout: do not
> lose staged removal), which reveals the bug in this case, but is
> otherwise unrelated.
> ---
Sign-off?
Just for the record, this patch fixes the testcase Miklos reported
earlier.
Ciao,
Dscho
next prev parent reply other threads:[~2009-01-02 22:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 20:54 unpack-trees: fix D/F conflict bugs in verify_absent Clemens Buchacher
2009-01-01 20:54 ` [PATCH 1/3] unpack-trees: handle failure " Clemens Buchacher
2009-01-01 20:54 ` [PATCH 2/3] unpack-trees: fix path search bug " Clemens Buchacher
2009-01-01 20:54 ` [PATCH 3/3] unpack-trees: remove redundant path search " Clemens Buchacher
2009-01-06 8:19 ` Junio C Hamano
2009-01-02 21:59 ` Johannes Schindelin [this message]
2009-01-03 14:01 ` [PATCH 2/3] unpack-trees: fix path search bug " Miklos Vajna
2009-01-02 21:59 ` Johannes Schindelin
2009-01-03 10:39 ` Clemens Buchacher
2009-01-03 12:53 ` Johannes Schindelin
2009-01-04 10:01 ` Junio C Hamano
2009-01-04 20:01 ` Clemens Buchacher
2009-01-06 19:35 ` Johannes Schindelin
2011-01-13 2:24 ` [RFC/PATCH 0/2] unpack-trees: handle lstat failures " Jonathan Nieder
2011-01-13 2:26 ` [PATCH 1/2] unpack-trees: handle lstat failure for existing directory Jonathan Nieder
2011-01-13 4:37 ` Miles Bader
2011-01-13 5:38 ` Jonathan Nieder
2011-01-13 2:28 ` [PATCH 2/2] unpack-trees: handle lstat failure for existing file Jonathan Nieder
2011-01-13 20:20 ` [RFC/PATCH 0/2] unpack-trees: handle lstat failures in verify_absent Clemens Buchacher
2009-01-01 21:28 ` unpack-trees: fix D/F conflict bugs " Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-12-16 23:24 Strange untracked file behaviour Miklos Vajna
2008-12-17 5:09 ` Johannes Schindelin
2008-12-17 14:38 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0901022244240.27818@racer \
--to=johannes.schindelin@gmx.de \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox