From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Paul Mackerras <paulus@samba.org>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] gitk: force focus to main window
Date: Thu, 18 Dec 2008 04:14:25 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0812180413240.14632@racer> (raw)
In-Reply-To: <18761.29020.237388.687560@cargo.ozlabs.ibm.com>
Hi,
On Thu, 18 Dec 2008, Paul Mackerras wrote:
> Johannes Sixt writes:
>
> > On msysGit, the focus is first on the (Tk) console. This console is
> > then hidden, but keeps the focus. Work around that by forcing the
> > focus onto the gitk window.
>
> Hmmm, I don't like doing focus -force unconditionally on all platforms.
> I hate it when applications decide they know best and override what the
> window manager decides.
>From my previous experience with my patches to gitk, I did not expect
otherwise. That is why I did not even bother with this one.
> At least put a if {[tk windowingsystem] eq "win32"} in there. (msysGit
> is a windows thing, isn't it?)
Yeah, because on other platforms, when you start gitk, you don't want it
to take focus. Yeah, right.
Ciao,
Dscho
next prev parent reply other threads:[~2008-12-18 3:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 11:50 [PATCH] gitk: force focus to main window Johannes Sixt
2008-12-17 21:38 ` Paul Mackerras
2008-12-18 3:14 ` Johannes Schindelin [this message]
2008-12-18 3:23 ` Jeff King
2008-12-18 4:09 ` Paul Mackerras
2008-12-18 7:30 ` [PATCH v2] gitk: force the focus to the main window on Windows Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0812180413240.14632@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox