Failing tests with WITH_BREAKING_CHANGES

Failing tests with WITH_BREAKING_CHANGES

[brian m. carlson]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

I have the following in `config.mak`:

----
DEVELOPER=1
CC=clang
GENERATE_COMPILATION_DATABASE=yes
WITH_RUST=1
USE_ASCIIDOCTOR=1
WITH_BREAKING_CHANGES=1
----

In this configuration, I've noticed some tests failing:

----
t0014-alias.sh                                   (Wstat: 256 (exited 1) Tests: 23 Failed: 2)
  Failed tests:  4, 8
  Non-zero exit status: 1
t1517-outside-repo.sh                            (Wstat: 256 (exited 1) Tests: 404 Failed: 2)
  Failed tests:  248-249
  Non-zero exit status: 1
----

These don't occur if I remove `WITH_BREAKING_CHANGES=1`, so they appear
to be related to that option.  However, I know we have a CI job for that
case, so it's unclear to me why these tests are failing; perhaps the CI
job is not testing what we think it's testing.

I noticed this because I plan to send out a series soon based on that
option and obviously I want to run the testsuite first.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]

Re: Failing tests with WITH_BREAKING_CHANGES

[Junio C Hamano]

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> I have the following in `config.mak`:
>
> ----
> DEVELOPER=1
> CC=clang
> GENERATE_COMPILATION_DATABASE=yes
> WITH_RUST=1
> USE_ASCIIDOCTOR=1
> WITH_BREAKING_CHANGES=1
> ----
>
> In this configuration, I've noticed some tests failing:
>
> ----
> t0014-alias.sh                                   (Wstat: 256 (exited 1) Tests: 23 Failed: 2)
>   Failed tests:  4, 8
>   Non-zero exit status: 1
> t1517-outside-repo.sh                            (Wstat: 256 (exited 1) Tests: 404 Failed: 2)
>   Failed tests:  248-249
>   Non-zero exit status: 1
> ----
>
> These don't occur if I remove `WITH_BREAKING_CHANGES=1`, so they appear
> to be related to that option.  However, I know we have a CI job for that
> case, so it's unclear to me why these tests are failing; perhaps the CI
> job is not testing what we think it's testing.

Does not immediately ring a bell for me.  All four integration
branches are OK in my builds.

> I noticed this because I plan to send out a series soon based on that
> option and obviously I want to run the testsuite first.