From: Taylor Blau <ttaylorr@openai.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Lin <davidzylin@gmail.com>,
git@vger.kernel.org, David Lin <davidlin@stripe.com>
Subject: Re: [PATCH v2] pack-bitmap: handle objects at bitmap position zero
Date: Tue, 28 Jul 2026 18:31:49 -0500 [thread overview]
Message-ID: <amk75SuhyHBbx-E8@com-79390> (raw)
In-Reply-To: <xmqq5x1yd968.fsf@gitster.g>
On Tue, Jul 28, 2026 at 03:46:39PM -0700, Junio C Hamano wrote:
> David Lin <davidzylin@gmail.com> writes:
>
> > `bitmap_position()` only returns a negative value when an object is not
> > present in the bitmap index.
> > ...
> > Also cover the non-pseudo-merge case by passing `HEAD` twice. The first
> > occurrence initializes the base from its stored bitmap, and the second
> > must recognize that position zero is already present.
> >
> > Helped-by: Taylor Blau <ttaylorr@openai.com>
> > Signed-off-by: David Lin <davidlin@stripe.com>
> > ---
> > Changes since v1:
> > - Clarify the bitmap disk load wordings.
> > - Add coverage for the non-pseudo-merge case.
>
> Thanks, both of you. Will queue.
This version looks good to me.
Thanks,
Taylor
prev parent reply other threads:[~2026-07-28 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 17:13 [PATCH] pack-bitmap: handle objects at bitmap position zero David Lin
2026-07-27 20:05 ` Taylor Blau
2026-07-28 13:40 ` David Lin
2026-07-28 13:52 ` [PATCH v2] " David Lin
2026-07-28 22:46 ` Junio C Hamano
2026-07-28 23:31 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amk75SuhyHBbx-E8@com-79390 \
--to=ttaylorr@openai.com \
--cc=davidlin@stripe.com \
--cc=davidzylin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox