Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Lin <davidzylin@gmail.com>
Cc: git@vger.kernel.org,  ttaylorr@openai.com,
	 David Lin <davidlin@stripe.com>
Subject: Re: [PATCH v2] pack-bitmap: handle objects at bitmap position zero
Date: Tue, 28 Jul 2026 15:46:39 -0700	[thread overview]
Message-ID: <xmqq5x1yd968.fsf@gitster.g> (raw)
In-Reply-To: <20260728135248.61304-1-davidlin@stripe.com> (David Lin's message of "Tue, 28 Jul 2026 09:52:48 -0400")

David Lin <davidzylin@gmail.com> writes:

> `bitmap_position()` only returns a negative value when an object is not
> present in the bitmap index.
> ...
> Also cover the non-pseudo-merge case by passing `HEAD` twice. The first
> occurrence initializes the base from its stored bitmap, and the second
> must recognize that position zero is already present.
>
> Helped-by: Taylor Blau <ttaylorr@openai.com>
> Signed-off-by: David Lin <davidlin@stripe.com>
> ---
> Changes since v1:
> - Clarify the bitmap disk load wordings.
> - Add coverage for the non-pseudo-merge case.

Thanks, both of you.  Will queue.

  reply	other threads:[~2026-07-28 22:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 17:13 [PATCH] pack-bitmap: handle objects at bitmap position zero David Lin
2026-07-27 20:05 ` Taylor Blau
2026-07-28 13:40   ` David Lin
2026-07-28 13:52 ` [PATCH v2] " David Lin
2026-07-28 22:46   ` Junio C Hamano [this message]
2026-07-28 23:31     ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5x1yd968.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=davidlin@stripe.com \
    --cc=davidzylin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ttaylorr@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox