From: Patrick Steinhardt <ps@pks.im>
To: Tian Yuchen <cat@malon.dev>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/3] environment: clean up repository config handling
Date: Fri, 7 Aug 2026 13:04:32 +0200 [thread overview]
Message-ID: <anW7wHfUxYj9cj0P@pks.im> (raw)
In-Reply-To: <20260807085932.3958759-1-cat@malon.dev>
On Fri, Aug 07, 2026 at 04:59:29PM +0800, Tian Yuchen wrote:
> Hi all,
>
> This series contains several cleanup patches for repository configuration
> handling.
>
> No functional changes are intended. The patches make the related code
> more consistent and easier to maintain by improving documentation,
> formatting, and the organization of repo_config_values.
>
> RFC:
> If there are other small cleanups in this area that would be useful to
> include, suggestions are welcome.
Somewhat unrelated to this patch series, but I was wondering whether you
plan to drop the limitation in `repo_config_values()` that requires that
the passed-in repository is `the_repository`. This limitation is
starting to create problems as more and more of our infrastructure is
migrating into `struct repo_config_values`, so using a different repo
than `the_repository` is starting to become harder and harder in our
codebase.
Thanks!
Patrick
next prev parent reply other threads:[~2026-08-07 11:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 11:53 [PATCH 0/3] environment: clean up repository config handling Tian Yuchen
2026-08-05 11:53 ` [PATCH 1/3] environment: simplify repository config getters Tian Yuchen
2026-08-05 21:49 ` Junio C Hamano
2026-08-05 11:53 ` [PATCH 2/3] environment: clarify repository config getter documentation Tian Yuchen
2026-08-05 21:38 ` Junio C Hamano
2026-08-06 8:49 ` Tian Yuchen
2026-08-05 11:53 ` [PATCH 3/3] environment: reorder variables in repo_config_values structure Tian Yuchen
2026-08-05 21:47 ` Junio C Hamano
2026-08-06 8:44 ` Tian Yuchen
2026-08-06 16:42 ` Junio C Hamano
2026-08-07 8:26 ` Tian Yuchen
2026-08-06 9:25 ` [PATCH v2 0/3] environment: clean up repository config handling Tian Yuchen
2026-08-06 9:25 ` [PATCH v2 1/3] environment: simplify repository config getters Tian Yuchen
2026-08-06 16:50 ` Junio C Hamano
2026-08-07 8:30 ` Tian Yuchen
2026-08-06 9:25 ` [PATCH v2 2/3] environment: clarify repository config getter documentation Tian Yuchen
2026-08-06 16:54 ` Junio C Hamano
2026-08-06 9:25 ` [PATCH v2 3/3] environment: remove inaccurate repo_config_values comments Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 0/3] environment: clean up repository config handling Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 1/3] environment: drop redundant NULL checks in config getters Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 2/3] environment: clarify repository config getter documentation Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 3/3] environment: remove inaccurate repo_config_values comments Tian Yuchen
2026-08-07 11:04 ` Patrick Steinhardt [this message]
2026-08-07 21:11 ` [PATCH v3 0/3] environment: clean up repository config handling Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anW7wHfUxYj9cj0P@pks.im \
--to=ps@pks.im \
--cc=cat@malon.dev \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox