Re: [PATCH v3] Move rust gitcore crate to a different subdirectory

["brian m. carlson" <sandals@crustytoothpaste.net>]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On 2026-09-09 at 01:38:58, Mike Hommey wrote:
> Having `Cargo.toml` at the top-level of the repository implies that one
> can run `cargo build` directly, but this doesn't produce anything useful
> on its own.
> 
> Additionally, when including the git source as a submodule of a Rust
> project, it prevents the git source from being included at all in the
> crate package because cargo skips directories that contain a Cargo.toml,
> assuming that everything in the directory is relevant to the crate.

So what I understand is that you have a project which has Git as a
submodule and you want to include the Git source code into the crate
package for that project.  In other words, you're vendoring Git to use
its C components, but not its Rust components.

If that's the case, how do you plan that to work in a few releases when
Git 3.0 comes out and the Rust components become mandatory?  If you
don't plan for it to work, wouldn't it be better to adopt a different
strategy now rather than implementing a workaround that will be broken
in a short time?
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]