Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tuomas Ahola <taahol@utu.fi>
Cc: Mike Hommey <mh@glandium.org>,  <git@vger.kernel.org>,
	 <ps@pks.im>, <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v3] Move rust gitcore crate to a different subdirectory
Date: Thu, 10 Sep 2026 05:21:36 -0700	[thread overview]
Message-ID: <xmqqwlst2t67.fsf@gitster.g> (raw)
In-Reply-To: <20260910062758.RcjdX%taahol@utu.fi> (Tuomas Ahola's message of "Thu, 10 Sep 2026 09:27:58 +0300")

Tuomas Ahola <taahol@utu.fi> writes:

> Mike Hommey <mh@glandium.org> wrote:
>
>> [...]
>
>> diff --git a/meson.build b/meson.build
>> index d86f2acd2b..b91d30666e 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -1782,7 +1782,7 @@ libgit_sources += version_def_h
>>  
>>  rust_option = get_option('rust')
>>  if rust_option.allowed()
>> -  subdir('src')
>> +  subdir('rust/src')
>>    libgit_c_args += '-DWITH_RUST'
>>  
>
> I think that's bound to fail---there's no meson.build in rust/src, right?

Thanks for catching it.  Indeed our CI builds are failing since this
topic was injested in 'seen'.

Will kick it out and wait for updates.

Thanks.

  reply	other threads:[~2026-09-10 12:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 23:22 [RFC PATCH] Move rust gitcore crate to a different subdirectory Mike Hommey
2026-02-05  0:10 ` brian m. carlson
2026-02-05  1:45   ` Mike Hommey
2026-02-05  2:06     ` brian m. carlson
2026-02-05  4:55       ` Mike Hommey
2026-02-09 22:48 ` [PATCH v2] " Mike Hommey
2026-09-09  1:38   ` [PATCH v3] " Mike Hommey
2026-09-09 19:54     ` Junio C Hamano
2026-09-10 12:09       ` Mike Hommey
2026-09-09 21:13     ` brian m. carlson
2026-09-10 12:05       ` Mike Hommey
2026-09-10  6:27     ` Tuomas Ahola
2026-09-10 12:21       ` Junio C Hamano [this message]
2026-09-10 12:10     ` [PATCH v4] " Mike Hommey
2026-09-10 17:45       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwlst2t67.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    --cc=taahol@utu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox