From: Patrick Steinhardt <ps@pks.im>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git.git (Oct 2026, #06)
Date: Wed, 21 Oct 2026 07:45:23 +0200 [thread overview]
Message-ID: <athRc1-tSEVgBupp@pks.im> (raw)
In-Reply-To: <20261020185101.GA6367@tb-raspi4>
On Tue, Oct 20, 2026 at 08:51:01PM +0200, Torsten Bögershausen wrote:
> > * ps/pack-check-bigfile-threshold (2026-10-14) 1 commit
> > - pack-check: fix bogus corruption report with core.bigFileThreshold
> >
>
> That does fail here - the read-only files was not overwritten.
> Patrick, can we get this extra line ?
>
> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index 16cc5d5dcb..a19bb27db7 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -544,6 +544,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' ' cd truncated-blob && blob=$(test-tool genrandom one 5k | git hash-object -t blob -w --stdin) && obj=.git/objects/$(test_oid_to_path $blob) && + chmod +w $obj && # Truncate the loose blob such that its header can still be # parsed, but reading the object data fails mid-stream.
This diff is quite mangled, let me untangle it:
diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
index 16cc5d5dcb..a19bb27db7 100755
--- a/t/t1450-fsck.sh
+++ b/t/t1450-fsck.sh
@@ -544,6 +544,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' '
cd truncated-blob &&
blob=$(test-tool genrandom one 5k | git hash-object -t blob -w --stdin) &&
obj=.git/objects/$(test_oid_to_path $blob) &&
+ chmod +w $obj &&
# Truncate the loose blob such that its header can still be
# parsed, but reading the object data fails mid-stream.
Ah, right, that makes sense. Makes me wonder why none of our tests in CI
hit this error. Weird.
Junio, as this patch series is already in "next", do you want me to send
a patch on top to fix it or shall I send a new version?
Thanks for the report!
Patrick
next prev parent reply other threads:[~2026-10-21 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 23:02 What's cooking in git.git (Oct 2026, #06) Junio C Hamano
2026-10-20 18:51 ` Torsten Bögershausen
2026-10-21 5:45 ` Patrick Steinhardt [this message]
2026-10-21 17:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=athRc1-tSEVgBupp@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox