From: Patrick Steinhardt <ps@pks.im>
To: Joy Gundu via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
"Kristoffer Haugsbakk@imap.fastmail.com>"
<kristofferhaugsbakk@fastmail.com>,
"Christian Couder>" <christian.couder@gmail.com>,
"Usman Akinyemi@imap.fastmail.com>" <usmanakinyemi202@gmail.com>,
Joie Joie <soniqjjj@gmail.com>
Subject: Re: [PATCH v2 2/2] config: move pack size limit into repo config
Date: Thu, 22 Oct 2026 13:30:34 +0200 [thread overview]
Message-ID: <atnz2koLCp6FMD0u@pks.im> (raw)
In-Reply-To: <05ae50b5daf0caea8666b0b7c8aaeb9f5c397017.1792662432.git.gitgitgadget@gmail.com>
On Thu, Oct 22, 2026 at 09:47:12AM +0000, Joy Gundu via GitGitGadget wrote:
> From: Joy Gundu <soniqjjj@gmail.com>
>
> The pack size limit is currently stored in a standalone global
> variable, even though it is repository configuration.
>
> Move the value into repo_config_values and update the configuration
> parser and pack-writing code to read it from the repository's
> configuration values.
>
> This removes one piece of global configuration state and helps
> make Git code easier to reuse as a library component.
This reads well to me, thanks.
Patrick
next prev parent reply other threads:[~2026-10-22 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 18:56 [PATCH] config: move pack size limit into repo config Joy via GitGitGadget
2026-10-20 19:02 ` Kristoffer Haugsbakk
2026-10-21 8:09 ` Patrick Steinhardt
2026-10-21 12:23 ` Joie Joie
2026-10-22 9:47 ` [PATCH v2 0/2] " Joy via GitGitGadget
2026-10-22 9:47 ` [PATCH v2 1/2] repo: zero-initialize configuration values Joy Gundu via GitGitGadget
2026-10-22 11:30 ` Patrick Steinhardt
2026-10-23 12:00 ` Joie Joie
2026-10-26 7:30 ` Patrick Steinhardt
2026-10-22 9:47 ` [PATCH v2 2/2] config: move pack size limit into repo config Joy Gundu via GitGitGadget
2026-10-22 11:30 ` Patrick Steinhardt [this message]
2026-10-22 11:30 ` [PATCH v2 0/2] " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atnz2koLCp6FMD0u@pks.im \
--to=ps@pks.im \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=soniqjjj@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox