[PATCH v2 0/2] config: move pack size limit into repo config

["Joy via GitGitGadget" <gitgitgadget@gmail.com>]

This series moves pack.packsizelimit from a standalone global variable into
struct repo_config_values, as part of the ongoing effort to reduce Git's
reliance on global state and make its code easier to reuse as a library.

The series includes two patches:

 1. Update repo_config_values_init() to use memset() for
    zero-initialization, while keeping the defaults that require explicit
    values.
 2. Move the pack size limit into repo_config_values and update the relevant
    code to read it from there.


Changes since v1
================

Thanks to Patrick Steinhardt for reviewing the first version and suggesting
the initialization cleanup.

Following his feedback, I've:

 * Added a preparatory patch to simplify how repository configuration values
   are initialized.
 * Reworked the main commit message to explain the existing problem before
   describing the change.
 * Removed the need to explicitly initialize the new pack size limit field
   to zero.


Testing
=======

I built Git and ran the relevant configuration and pack-object tests:

 * make -j2 — passed.
 * t1300-config.sh — 518 successful tests.
 * t5300-pack-object.sh — 63 passed, 2 skipped, 0 failed.

Both test runs reported permission errors during cleanup after the tests had
completed.

Joy Gundu (2):
  repo: zero-initialize configuration values
  config: move pack size limit into repo config

 builtin/pack-objects.c |  2 +-
 environment.c          | 17 +++--------------
 environment.h          |  3 +--
 object-file.c          |  6 ++++--
 4 files changed, 9 insertions(+), 19 deletions(-)


base-commit: 47fdf2208c5b94c8cc01c106b8f7c85efb91c926
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2271%2FJoiejoie1%2Foutreachy%2Fglobal-state-mini-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2271/Joiejoie1/outreachy/global-state-mini-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/2271

Range-diff vs v1:

 -:  ---------- > 1:  df93a2a86c repo: zero-initialize configuration values
 1:  e3e36c3459 ! 2:  05ae50b5da config: move pack size limit into repo config
     @@ Metadata
       ## Commit message ##
          config: move pack size limit into repo config
      
     -    Store the pack.packsizelimit value in repository configuration
     -    rather than keeping it in a standalone global variable for the repository.
     +    The pack size limit is currently stored in a standalone global
     +    variable, even though it is repository configuration.
      
     -    Update the configuration parser and pack-writing code to read
     -    the value from repo_config_values rather than a global variable.
     +    Move the value into repo_config_values and update the configuration
     +    parser and pack-writing code to read it from the repository's
     +    configuration values.
      
     -    This change removes one piece of global configuration state from Git
     -    and helps make Git code easier to reuse as a library component.
     +    This removes one piece of global configuration state and helps
     +    make Git code easier to reuse as a library component.
      
          Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
      
     @@ environment.c: int git_default_config(const char *var, const char *value,
       		return 0;
       	}
       
     -@@ environment.c: void repo_config_values_init(struct repo_config_values *cfg)
     - 	cfg->check_stat = 1;
     - 	cfg->zlib_compression_level = Z_BEST_SPEED;
     - 	cfg->pack_compression_level = Z_DEFAULT_COMPRESSION;
     -+	cfg->pack_size_limit = 0;
     - 	cfg->precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
     - 	cfg->core_sparse_checkout_cone = 0;
     - 	cfg->warn_on_object_refname_ambiguity = 1;
      
       ## environment.h ##
      @@ environment.h: struct repo_config_values {

-- 
gitgitgadget