Re: [PATCH v2 4/6] odb/source-files: simplify directory duplication detection

[Patrick Steinhardt <ps@pks.im>]

On Tue, Oct 27, 2026 at 01:13:49PM +0100, Christian Couder wrote:
> On Fri, Oct 23, 2026 at 2:48 PM Patrick Steinhardt <ps@pks.im> wrote:
> 
> > -/*
> > - * NEEDSWORK: we're using "core.ignoreCase" to deduplicate alternates that
> > - * _may_ be the same. This requires quite a bit of boilerplate for dubious
> > - * benefit:
> > - *
> > - *   - Duplicating alternates should really only lead to regressed performance.
> > - *
> > - *   - We don't properly resolve symlinks or mointpoints, so we may still end
> > - *     up duplicating alternates.
> > - *
> > - *   - The value may be lying, in which case we might deduplicate alternates
> > - *     that are in fact not mapping to the same directory.
> > - *
> > - * We should investigate whether we can remove this whole mechanism outright.
> > - */
> 
> Removing this NEEDSWORK isn't mentioned in the commit message. I agree
> that the boilerplate is reduced with the new implementation, but I
> think the points regarding mount points and a wrong `core.ignoreCase`
> might still be interesting.

Yeah, that's a fair point. Will add it back in.

Patrick