From: Justin Tobler <jltobler@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH v4 3/4] object-file: explicitly write ".keep" lockfile
Date: Tue, 27 Oct 2026 13:32:28 -0500 [thread overview]
Message-ID: <auDt1rq4a_ENlQiK@denethor> (raw)
In-Reply-To: <auDsoWt5XVXw2hPN@denethor>
On 26/10/27 01:26PM, Justin Tobler wrote:
> On 26/10/26 09:08AM, Karthik Nayak wrote:
> > Justin Tobler <jltobler@gmail.com> writes:
> > > + if (write_in_full(fd, contents.buf, contents.len) < 0) {
> > > + ret = error_errno(_("unable to write '%s'"), lock_path.buf);
> > > + close(fd);
> > > + unlink(lock_path.buf);
> >
> > Should we use `unlink_or_warn()` here?
>
> Ya, adding a warning here would probably be useful. I'll go ahead and do
> so in the next version.
I just noticed that this series was already merged to next, so I can
just send this change a separate patch.
-Justin
next prev parent reply other threads:[~2026-10-27 18:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 2:28 [PATCH 0/3] object-file: fix ".keep" lockfile ownership in ODB transactions Justin Tobler
2026-10-16 2:28 ` [PATCH 1/3] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-16 6:58 ` Patrick Steinhardt
2026-10-16 17:30 ` Justin Tobler
2026-10-16 2:29 ` [PATCH 2/3] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-16 6:58 ` Patrick Steinhardt
2026-10-16 18:37 ` Justin Tobler
2026-10-16 2:29 ` [PATCH 3/3] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-16 6:58 ` Patrick Steinhardt
2026-10-16 19:22 ` Justin Tobler
2026-10-16 21:37 ` [PATCH v2 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Justin Tobler
2026-10-16 21:37 ` [PATCH v2 1/4] pack-write: make index-pack output comment hash agnostic Justin Tobler
2026-10-16 21:37 ` [PATCH v2 2/4] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-16 21:37 ` [PATCH v2 3/4] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-19 6:14 ` Patrick Steinhardt
2026-10-19 21:44 ` Justin Tobler
2026-10-16 21:37 ` [PATCH v2 4/4] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-19 6:14 ` Patrick Steinhardt
2026-10-20 13:28 ` [PATCH v3 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Justin Tobler
2026-10-20 13:28 ` [PATCH v3 1/4] pack-write: make index-pack output comment hash agnostic Justin Tobler
2026-10-20 13:28 ` [PATCH v3 2/4] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-20 13:28 ` [PATCH v3 3/4] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-20 14:26 ` Patrick Steinhardt
2026-10-20 15:51 ` Justin Tobler
2026-10-21 16:47 ` Junio C Hamano
2026-10-20 13:29 ` [PATCH v3 4/4] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-20 14:15 ` [PATCH v3 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Patrick Steinhardt
2026-10-21 18:25 ` [PATCH v4 " Justin Tobler
2026-10-21 18:25 ` [PATCH v4 1/4] pack-write: make index-pack output comment hash agnostic Justin Tobler
2026-10-26 15:01 ` Karthik Nayak
2026-10-26 15:44 ` Justin Tobler
2026-10-21 18:25 ` [PATCH v4 2/4] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-21 18:25 ` [PATCH v4 3/4] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-26 16:08 ` Karthik Nayak
2026-10-27 18:26 ` Justin Tobler
2026-10-27 18:32 ` Justin Tobler [this message]
2026-10-26 21:51 ` Karthik Nayak
2026-10-21 18:25 ` [PATCH v4 4/4] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-26 21:49 ` Karthik Nayak
2026-10-22 5:56 ` [PATCH v4 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auDt1rq4a_ENlQiK@denethor \
--to=jltobler@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox