Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Srujith A Poojary via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Usman Akinyemi <usmanakinyemi202@gmail.com>,
	Srujith A Poojary <poojarysrujith@gmail.com>
Subject: Re: [PATCH v4] [Outreachy PATCH] t0001: avoid pipes in test scripts
Date: Fri, 30 Oct 2026 08:24:07 +0100	[thread overview]
Message-ID: <auRGDmW0R-Ipn-gT@pks.im> (raw)
In-Reply-To: <pull.2260.v4.git.1793284463139.gitgitgadget@gmail.com>

On Thu, Oct 29, 2026 at 02:34:23PM +0000, Srujith A Poojary via GitGitGadget wrote:
> Range-diff vs v3:
> 
>  1:  a70ccdf49e ! 1:  4373eef413 [Outreachy PATCH] t0001: avoid pipes in test scripts
>      @@ Commit message
>           [Outreachy PATCH] t0001: avoid pipes in test scripts
>       
>           Avoid piping output from git version directly into sed to ensure
>      -
>           that any command failure is properly caught by test scripts.
>       
>           Signed-off-by: Srujith Poojary <poojarysrujith@gmail.com>

Thanks, this version looks good to me.

Patrick

  reply	other threads:[~2026-10-30  7:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18  4:55 [PATCH] [Outreachy PATCH] t0001: avoid pipes in test scripts Srujith A Poojary via GitGitGadget
2026-10-21 22:03 ` Usman Akinyemi
2026-10-22 10:50 ` [PATCH v2] " Srujith A Poojary via GitGitGadget
2026-10-22 10:53   ` Srujith Poojary
2026-10-22 17:24   ` Junio C Hamano
2026-10-23  4:34     ` Srujith Poojary
2026-10-23  5:13 ` [PATCH v3] " Srujith A Poojary via GitGitGadget
2026-10-23 16:23   ` Srujith Poojary
2026-10-29 12:12   ` Patrick Steinhardt
2026-10-29 14:36     ` Srujith Poojary
2026-10-29 14:34 ` [PATCH v4] " Srujith A Poojary via GitGitGadget
2026-10-30  7:24   ` Patrick Steinhardt [this message]
2026-10-30  8:05     ` Srujith Poojary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auRGDmW0R-Ipn-gT@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=poojarysrujith@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox