From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
Jeff King <peff@peff.net>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v2 0/7] Git 3.0: restrict hex object IDs to lowercase only
Date: Mon, 2 Nov 2026 10:53:19 +0100 [thread overview]
Message-ID: <auhdjw9w1lcoFIiC@pks.im> (raw)
In-Reply-To: <xmqq7bivmwct.fsf@gitster.g>
On Mon, Nov 02, 2026 at 01:11:14AM -0800, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > As far as I can tell, Git has always emitted hex object IDs in
> > lowercase, but our object ID parser accepts both uppercase and
> > lowercase. This leads to much software relying on hex object IDs being
> > broken because it doesn't handle uppercase object IDs and this can even
> > lead to security problems when people assume that an object ID has a
> > unique hex form.
>
> As far as I can recall, this had quite a lot of discussion during v1
> (or was it RFC?) but nobody seems to have been reacted to this
> round. Can anybody give it an eyeball (or two) and tell us that the
> iteration now is in line with what was discussed during the review
> of the previous round, so that we can mark it for 'next'?
I've added this to my todo list for this week.
Patrick
prev parent reply other threads:[~2026-11-02 9:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 23:32 [RFC PATCH 0/6] Git 3.0: restrict hex object IDs to lowercase only brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 1/6] hex: add functionality for lowercase-only hex brian m. carlson
2026-07-31 7:38 ` Junio C Hamano
2026-08-25 15:39 ` Junio C Hamano
2026-08-25 21:44 ` brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 2/6] hex: allow specifying hex type with hex2chr brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 3/6] hex: make hex_to_bytes accept kind of hex to use brian m. carlson
2026-07-31 7:38 ` Junio C Hamano
2026-08-01 14:35 ` Jeff King
2026-07-29 23:32 ` [RFC PATCH 4/6] hex: label usages of hex parsing for object IDs brian m. carlson
2026-07-31 3:24 ` Junio C Hamano
2026-08-25 16:11 ` Junio C Hamano
2026-07-29 23:32 ` [RFC PATCH 5/6] object-name: use hexval brian m. carlson
2026-08-25 16:19 ` Junio C Hamano
2026-08-25 19:44 ` Elijah Newren
2026-08-25 21:41 ` brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 6/6] hex: allow only lowercase object IDs in breaking changes mode brian m. carlson
2026-07-31 7:48 ` Junio C Hamano
2026-07-31 12:33 ` Junio C Hamano
2026-08-02 22:09 ` brian m. carlson
2026-08-04 19:32 ` Junio C Hamano
2026-08-04 21:46 ` brian m. carlson
2026-08-05 3:09 ` Michael Montalbo
2026-08-25 9:04 ` Phillip Wood
2026-08-25 21:36 ` brian m. carlson
2026-09-07 13:37 ` Phillip Wood
2026-08-25 16:36 ` Junio C Hamano
2026-08-25 19:44 ` Elijah Newren
2026-07-30 8:21 ` [RFC PATCH 0/6] Git 3.0: restrict hex object IDs to lowercase only Junio C Hamano
2026-07-30 21:18 ` brian m. carlson
2026-08-01 14:45 ` Jeff King
2026-08-01 18:22 ` Junio C Hamano
2026-08-02 21:55 ` brian m. carlson
2026-09-07 19:59 ` [PATCH v2 0/7] " brian m. carlson
2026-09-07 19:59 ` [PATCH v2 1/7] hex: add functionality for lowercase-only hex brian m. carlson
2026-09-07 19:59 ` [PATCH v2 2/7] hex: allow specifying hex type with hex2chr brian m. carlson
2026-09-07 19:59 ` [PATCH v2 3/7] hex: make hex_to_bytes accept kind of hex to use brian m. carlson
2026-09-07 19:59 ` [PATCH v2 4/7] hex: label usages of hex parsing for object IDs brian m. carlson
2026-09-07 19:59 ` [PATCH v2 5/7] object-name: use hexval brian m. carlson
2026-09-07 19:59 ` [PATCH v2 6/7] t5324: adjust tests for corrupt commit-graph brian m. carlson
2026-09-07 19:59 ` [PATCH v2 7/7] hex: allow only lowercase object IDs in breaking changes mode brian m. carlson
2026-11-02 9:11 ` [PATCH v2 0/7] Git 3.0: restrict hex object IDs to lowercase only Junio C Hamano
2026-11-02 9:53 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auhdjw9w1lcoFIiC@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox