From: Patrick Steinhardt <ps@pks.im>
To: phillip.wood@dunelm.org.uk
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [PATCH 8/8] t/test-lib: make feature-testbed job more accessible
Date: Mon, 2 Nov 2026 12:16:05 +0100 [thread overview]
Message-ID: <auhw9ft8vVGAHP00@pks.im> (raw)
In-Reply-To: <617fa828-387a-4f4a-bc85-099ca691bca4@gmail.com>
On Wed, Oct 28, 2026 at 02:33:15PM +0000, Phillip Wood wrote:
> On 27/10/2026 21:23, Jeff King wrote:
> >
> > IMHO this whole thing isn't really worth the complexity, but if we are
> > going to do it, should it be "make FEATURE_TESTBED=1", and then that
> > enables the right build knobs, and test-lib.sh respects that variable
> > coming from BUILD-OPTIONS rather than the command line?
>
> If we want to be able to recreate the CI job locally then I agree a Makefile
> flag is a better solution. I seem to remember Ævar trying to add Makefile
> targets for some of the CI jobs so they could be run locally.
As said elsewhere though this doesn't fit my own use case, which is to
quickly re-run a patch series with these features enabled and disabled.
So I'll just drop this patch altogether.
Thanks!
Patrick
next prev parent reply other threads:[~2026-11-02 11:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 8:18 [PATCH 0/8] ci: consolidate test variables Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 1/8] ci: consolidate setup of test environment Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 2/8] ci/lib: always set GIT_TEST_USE_SET_E on Linux jobs Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 3/8] ci/lib: deduplicate test variables by pattern matching Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 4/8] ci/lib: merge switches for specific job names Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 5/8] t: honor default ref storage format Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 6/8] ci/lib: add another NO_RUST build using glibc Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 7/8] ci: don't override initial branch name in testbed job Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 8/8] t/test-lib: make feature-testbed job more accessible Patrick Steinhardt
2026-10-27 14:53 ` Phillip Wood
2026-10-27 20:59 ` Junio C Hamano
2026-10-28 7:41 ` Patrick Steinhardt
2026-10-27 21:23 ` Jeff King
2026-10-27 21:47 ` Junio C Hamano
2026-10-28 7:39 ` Patrick Steinhardt
2026-10-28 14:33 ` Phillip Wood
2026-11-02 11:16 ` Patrick Steinhardt [this message]
2026-10-27 15:00 ` [PATCH 0/8] ci: consolidate test variables Phillip Wood
2026-10-27 20:59 ` Junio C Hamano
2026-10-27 21:24 ` Jeff King
2026-10-28 14:40 ` Toon Claes
2026-11-02 11:17 ` [PATCH v2 0/7] " Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 1/7] ci: consolidate setup of test environment Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 2/7] ci/lib: always set GIT_TEST_USE_SET_E on Linux jobs Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 3/7] ci/lib: deduplicate test variables by pattern matching Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 4/7] ci/lib: merge switches for specific job names Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 5/7] t: honor default ref storage format Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 6/7] ci/lib: add another NO_RUST build using glibc Patrick Steinhardt
2026-11-02 11:17 ` [PATCH v2 7/7] ci: don't override initial branch name in testbed job Patrick Steinhardt
2026-11-02 16:03 ` [PATCH v2 0/7] ci: consolidate test variables Phillip Wood
2026-11-04 6:36 ` Jeff King
2026-11-04 18:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auhw9ft8vVGAHP00@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox