Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine

[Patrick Steinhardt <ps@pks.im>]

On Tue, Nov 03, 2026 at 01:05:29PM +0100, Kristofer Karlsson wrote:
> On Tue, Nov 03, 2026 at 12:00 PM Patrick Steinhardt <ps@pks.im> wrote:
> > So this here isn't fully correct as it does not account for all cases.
> > We'd have to read the object storage format extension to figure out
> > where the primary object directory lives.
> 
> Good point.  I can rework the patch to make it easier to integrate
> with your ps/odb-object-storage-extension topic, by having the files
> source remember its default object directory in
> files->default_object_dir where it decides it, and comparing against
> that instead of hardcoding <commondir>/objects in the check.  Then
> your topic only has to change how the default is decided, and the
> check follows.  Something like this, if you want:

Note that this topic is already merged to "next", so in theory you could
rebase your patch on top of it now.

> > This makes me wonder whether the better fix would be to stop modifying
> > the primary object directory and instead we simply append the quarantine
> > directory to alternates.
> [...]
> 
> That does sound like the cleaner fix.  Since you are already deep into
> this area, I would be happy to drop the fix and wait for that instead.
> I expect very few users to be affected in practice: mostly git hosts
> with many hidden refs, which is the case bcec6780b2 was about.
> 
> In that case I could send just the tests, with the hidden refs case
> marked as test_expect_failure, so that it is covered once a long-term
> fix lands.  Or, if you would rather have a short-term fix in the
> meantime, I can send a v3 with the change above.

I certainly do care about this case and would like to see this fixed :)
I'd like to get Justin's opinion on that proposal first though, as he's
worked on transactions quite extensively over the last couple months.

Patrick