Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 Jeff King <peff@peff.net>,  Justin Tobler <jltobler@gmail.com>,
	 Kristofer Karlsson <krka@spotify.com>
Subject: Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine
Date: Mon, 02 Nov 2026 16:37:34 -0800	[thread overview]
Message-ID: <xmqq1p92g375.fsf@gitster.g> (raw)
In-Reply-To: <pull.2285.v2.git.1793619933300.gitgitgadget@gmail.com> (Kristofer Karlsson via GitGitGadget's message of "Mon, 02 Nov 2026 11:45:33 +0000")

"Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com>
writes:

>     Changes since v1:
>     
>      * Changed the rule to "an alternate that is ourselves is not a source
>        of alternate refs", as Peff described it.
>     
>      * Added a "borrowed" flag to alternates, set when they are loaded,
>        which says whether they come from another repository, and used it for
>        --alternate-refs. Our own object directory is recognized either as
>        /objects or as the parent of GIT_QUARANTINE_PATH.
>     
>      * Documented this for --alternate-refs.
>     
>      * Added tests for rev-list --alternate-refs in a pre-receive hook, for
>        our own object directory set up as an alternate by hand, and for a
>        quarantine outside of the commondir.

All of the above changes make sense to me.

This unfortunately crashes with Patrick's odb-reload-alternates
series, but let me see if I can get a reasonable conflict resolution
or if it is more reasonable to ask you to rebase this on the other
topic.

Thanks.

  reply	other threads:[~2026-11-03  0:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 15:18 [PATCH] odb: do not list our own refs as alternate refs in the quarantine Kristofer Karlsson via GitGitGadget
2026-10-29 16:57 ` Justin Tobler
2026-10-30 11:29   ` Kristofer Karlsson
2026-10-29 17:24 ` Junio C Hamano
2026-10-30 11:51   ` Kristofer Karlsson
2026-10-30 16:05     ` Junio C Hamano
2026-10-30 18:17     ` Jeff King
2026-11-02 11:45 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-11-03  0:37   ` Junio C Hamano [this message]
2026-11-03  1:12     ` Junio C Hamano
2026-11-03 10:19       ` Kristofer Karlsson
2026-11-03 11:00   ` Patrick Steinhardt
2026-11-03 12:05     ` Kristofer Karlsson
2026-11-03 12:26       ` Patrick Steinhardt
2026-11-03 21:53         ` Justin Tobler
2026-11-04 10:32           ` Kristofer Karlsson
2026-11-04 16:58             ` Justin Tobler
2026-11-04  2:48   ` Jeff King
2026-11-04 10:25     ` Kristofer Karlsson
2026-11-04 18:05       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1p92g375.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jltobler@gmail.com \
    --cc=krka@spotify.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox