From: Junio C Hamano <gitster@pobox.com>
To: Kristofer Karlsson <krka@spotify.com>
Cc: Jeff King <peff@peff.net>,
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine
Date: Wed, 04 Nov 2026 10:05:48 -0800 [thread overview]
Message-ID: <xmqq4idw320z.fsf@gitster.g> (raw)
In-Reply-To: <CAL71e4OreARF+dbCU3S8-_umrFEptPLPUiPDH3SYBx6OYjVpfg@mail.gmail.com> (Kristofer Karlsson's message of "Wed, 4 Nov 2026 11:25:38 +0100")
Kristofer Karlsson <krka@spotify.com> writes:
>> That's how _we_ use them in the internal callers, but it's a rev-list
>> option. So we can't say how they are used elsewhere. That said, I think
>> this is a totally reasonable tightening of the definition for general
>> use.
>
> Good point. I will reword that part of the commit message so that it
> does not rely on how the connectivity check uses them. It also seems
> in line with what we already do when loading alternates, where
> listing the object directory itself is ignored as a common mistake;
> inside the quarantine, that check just compares against the
> quarantine instead of our own object directory.
Sounds very good.
Thanks for coming up with a good way forward.
prev parent reply other threads:[~2026-11-04 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:18 [PATCH] odb: do not list our own refs as alternate refs in the quarantine Kristofer Karlsson via GitGitGadget
2026-10-29 16:57 ` Justin Tobler
2026-10-30 11:29 ` Kristofer Karlsson
2026-10-29 17:24 ` Junio C Hamano
2026-10-30 11:51 ` Kristofer Karlsson
2026-10-30 16:05 ` Junio C Hamano
2026-10-30 18:17 ` Jeff King
2026-11-02 11:45 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-11-03 0:37 ` Junio C Hamano
2026-11-03 1:12 ` Junio C Hamano
2026-11-03 10:19 ` Kristofer Karlsson
2026-11-03 11:00 ` Patrick Steinhardt
2026-11-03 12:05 ` Kristofer Karlsson
2026-11-03 12:26 ` Patrick Steinhardt
2026-11-03 21:53 ` Justin Tobler
2026-11-04 10:32 ` Kristofer Karlsson
2026-11-04 16:58 ` Justin Tobler
2026-11-04 2:48 ` Jeff King
2026-11-04 10:25 ` Kristofer Karlsson
2026-11-04 18:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4idw320z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jltobler@gmail.com \
--cc=krka@spotify.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox