Re: [PATCH v2] config: honor file permission bits

[Patrick Steinhardt <ps@pks.im>]

On Tue, Nov 03, 2026 at 11:11:18AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Nit: a curious reader might wonder why such in-tree files don't need
> > such protection.
> 
> But isn't it self evident that repository contents are supposed to
> be mutable, and you are not even supposed to muck with filesystem
> level tools like chmod or mv to begin with?

Maybe? I guess. In any case, no user has ever asked about this, so it's
probably okay. Not that any user has asked about the proposed new
behaviour either, as far as I know.

> >> +		error_errno(_("file %s unwritable"), config_filename);
> >
> > Should we quote '%s' here? The function is quite inconsistent, where it
> > sometimes quotes and sometimes doesn't. I'd say that quoting is the
> > better choice though.
> 
> While it probably makes sense, many of the existing messages in the
> same function also lack the quote.  I would rather leave it for
> others to clean up the subsystem as a whole, as I expect there would
> probably be a huge fallout in expected test output ;-).

I don't think the other messages would need to be adapted. We already
have a mixture of both styles in this files, so I'd prefer to at least
not make the status quo worse by adding more instances that we know to
be suboptimal.

In any case, these are just nits and I don't feel strongly about any of
them.

Patrick