From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] config: honor file permission bits
Date: Thu, 05 Nov 2026 10:12:37 -0800 [thread overview]
Message-ID: <xmqqwlqruoyy.fsf@gitster.g> (raw)
In-Reply-To: <auyEPBEDUziv4w8u@pks.im> (Patrick Steinhardt's message of "Thu, 5 Nov 2026 14:27:24 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> I don't think the other messages would need to be adapted. We already
> have a mixture of both styles in this files, so I'd prefer to at least
> not make the status quo worse by adding more instances that we know to
> be suboptimal.
>
> In any case, these are just nits and I don't feel strongly about any of
> them.
I scanned the entire file and got the impression that majority of
the messages were without quotes. While I agree with you that
should be fixed, the patch followed that majority.
You are welcome to direct somebody else to go in and fix all of
them, but I do not want to see you doing so yourself, as your time
and productivity are more valuable elsewhere ;-)
prev parent reply other threads:[~2026-11-05 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 14:27 [RFC/PATCH] config: honor file permission bits Junio C Hamano
2026-10-22 20:59 ` Junio C Hamano
2026-10-22 21:08 ` brian m. carlson
2026-10-22 23:29 ` Junio C Hamano
2026-10-23 8:23 ` Patrick Steinhardt
2026-10-23 14:54 ` Junio C Hamano
2026-10-26 8:40 ` Patrick Steinhardt
2026-10-26 15:01 ` Junio C Hamano
2026-10-26 14:59 ` [PATCH v2] " Junio C Hamano
2026-11-03 10:34 ` Patrick Steinhardt
2026-11-03 19:11 ` Junio C Hamano
2026-11-05 13:27 ` Patrick Steinhardt
2026-11-05 18:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwlqruoyy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox